------=_Part_30742_1836830.1224160959938 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, I'm currently hacking on the multimonitor support (there is a long thread in the plasma mailing list for reference). With two monitors plugged in, kwin frequently crashes in Workspace::clientArea( clientAreaOption, int, int ). The problem is the screenarea/workarea arrays are sometimes smaller than expected. The attached patch works around the crash by simply testing the size of the arrays. I guess it's not the definitive solution but at least it avoids the crash. Ok to commit? g ------=_Part_30742_1836830.1224160959938 Content-Type: text/plain; name=kwin-crashfix.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fmddtbi00 Content-Disposition: attachment; filename=kwin-crashfix.diff SW5kZXg6IGtkZWJhc2Uvd29ya3NwYWNlL2t3aW4vZ2VvbWV0cnkuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGtkZWJhc2Uvd29ya3NwYWNlL2t3aW4vZ2VvbWV0cnkuY3BwCShyZXZpc2lvbiA4NzE5MTMpCisr KyBrZGViYXNlL3dvcmtzcGFjZS9rd2luL2dlb21ldHJ5LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjMwLDEzICsyMzAsMzAgQEAKICAgICAgICAgZGVza3RvcCA9IGN1cnJlbnREZXNrdG9wKCk7CiAg ICAgaWYoIHNjcmVlbiA9PSAtMSApCiAgICAgICAgIHNjcmVlbiA9IGFjdGl2ZVNjcmVlbigpOwor ICAgIAogICAgIFFEZXNrdG9wV2lkZ2V0ICpkZXNrdG9wd2lkZ2V0ID0gS0FwcGxpY2F0aW9uOjpk ZXNrdG9wKCk7Ci0gICAgUVJlY3Qgc2FyZWEgPSAhc2NyZWVuYXJlYS5pc0VtcHR5KCkgLy8gbWF5 IGJlIGVtcHR5IGR1cmluZyBLV2luIGluaXRpYWxpemF0aW9uCi0gICAgICAgID8gc2NyZWVuYXJl YVsgZGVza3RvcCBdWyBzY3JlZW4gXQotICAgICAgICA6IGRlc2t0b3B3aWRnZXQtPnNjcmVlbkdl b21ldHJ5KCBzY3JlZW4gKTsKLSAgICBRUmVjdCB3YXJlYSA9IHdvcmthcmVhWyBkZXNrdG9wIF0u aXNOdWxsKCkKLSAgICAgICAgPyBRQXBwbGljYXRpb246OmRlc2t0b3AoKS0+Z2VvbWV0cnkoKQot ICAgICAgICA6IHdvcmthcmVhWyBkZXNrdG9wIF07CisgICAgUVJlY3Qgc2FyZWE7CisgICAgaWYg KGRlc2t0b3AgPCBzY3JlZW5hcmVhLnNpemUoKSAmJiBzY3JlZW4gPCBzY3JlZW5hcmVhWyBkZXNr dG9wIF0uc2l6ZSgpKQorICAgICAgICB7CisgICAgICAgIHNhcmVhID0gc2NyZWVuYXJlYVsgZGVz a3RvcCBdWyBzY3JlZW4gXTsKKyAgICAgICAgfQorICAgIGVsc2UKKyAgICAgICAgeworICAgICAg ICBrRGVidWcoKSA8PCAiTm8gc3VjaCBkZXNrdG9wL3NjcmVlbiIgPDwgZGVza3RvcCA8PCBzY3Jl ZW47CisgICAgICAgIHNhcmVhID0gZGVza3RvcHdpZGdldC0+c2NyZWVuR2VvbWV0cnkoIHNjcmVl biApOworICAgICAgICB9CisKKyAgICBRUmVjdCB3YXJlYTsKKyAgICBpZiAoZGVza3RvcCA8IHdv cmthcmVhLnNpemUoKSkKKyAgICAgICAgeworICAgICAgICB3YXJlYSA9IHdvcmthcmVhWyBkZXNr dG9wIF07CisgICAgICAgIH0KKyAgICBlbHNlCisgICAgICAgIHsKKyAgICAgICAga0RlYnVnKCkg PDwgIk5vIHN1Y2ggZGVza3RvcCIgPDwgZGVza3RvcDsKKyAgICAgICAgd2FyZWEgPSBRQXBwbGlj YXRpb246OmRlc2t0b3AoKS0+Z2VvbWV0cnkoKTsKKyAgICAgICAgfQorCiAgICAgc3dpdGNoIChv cHQpCiAgICAgICAgIHsKICAgICAgICAgY2FzZSBNYXhpbWl6ZUFyZWE6Cg== ------=_Part_30742_1836830.1224160959938 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin ------=_Part_30742_1836830.1224160959938--