[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Magic Lamp Minimize Effect
From:       Martin Graesslin <ubuntu () martin-graesslin ! com>
Date:       2008-08-04 9:14:37
Message-ID: 200808041114.45686.ubuntu () martin-graesslin ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Montag, 4. August 2008 00:14:39 schrieb Sebastian Kügler:
> On Sunday 03 August 2008 19:24:34 Martin Graesslin wrote:
> > Am Sonntag, 3. August 2008 18:15:36 schrieb Sebastian Kügler:
> > > On Wednesday 30 July 2008 10:01:31 Martin Graesslin wrote:
> > > > I started to work on the magic lamp minimize effect as wished in bug
> > > > #167387. (That happens if you are bored in the evening and don't want
> > > > to work on cube ;-) )
> > > >
> > > > So here is the first result. As always I'm glad about feedback.
> > >
> > > After some time of using it, I still love it (will keep it as minimize
> > > effect, I think :)).
> >
> > Quite a point where I start to miss that I'm now using packaged KDE and
> > not trunk as work environment any more.
>
> (-: OTOH, it's a good sign that more an more people start relying on
> packages. It means we actually run what we ask our users to run, it's a
> sign of KDE4 maturing...
>
> > > Right now the minization is done into a fixed size rect behind the
> > > taskbar. It would be nice if the effect used the width of the taskbar
> > > item to scale down to. The minimize effect does the same, so basically
> > > the window is scaled from window size to taskbaritem size. Did you try
> > > that, did it work visually?
> >
> > Actually I had not tried. But here's the patch. It's hard to say which
> > version looks better. Personally I don't mind, but the first version had
> > some glitches (hardly visible in that speed).
>
> What do you mean with first version exactly? The first patch you sent for
> review (before you committed it)?
Exactly. I am not totally sure, but I think it is the same as the version 
which is committed.
>
> In any case, impressed  by the speed of your reply+patch, awesome :)
:-) Kdevelop was open with the files when I read your mail and I knew where I 
had to put the changes.
>
> I'm running it now, and it does exactly what I meant. I find it quite
> 'round' now. I'll let you now if I get ideas for further improvements,
> though I think it's in really fine state now.
Just test it a little bit and if you think it's right we can commit this 
change.
>
> Thanks for this cool effect :)
You're welcome :-)

["signature.asc" (application/pgp-signature)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]