[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Wobbly Effect
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2008-04-18 12:25:21
Message-ID: 200804181425.21746.l.lunak () suse ! cz
[Download RAW message or body]

On Thursday 17 of April 2008, cedric wrote:
> Hello everyone, I know that feature freeze for 4.1 is passed, but i'd like
> to commit the wobbly window effect in svn for kde 4.1

 There still is a month for that, what needs to be done by the end of this 
week is adding such a feature to 
http://techbase.kde.org/index.php?title=Schedules/KDE4/4.1_Feature_Plan .

> you can see a video here : http://vally8.free.fr/pamoi/kwin_wobbly.ogg
> the video is inversed on the Y axis, I don't understand why....
> and the desktop is a litle broken (plasma sprint) so I think it is not a
> nice video to show to the outside world...
>
> the last patch is attached (I hope...)


> Index: effects/wobblywindows.desktop
> ===========================
...
> +X-KDE-Ordering=80

 http://lists.kde.org/?l=kwin&m=120395261420290&w=2 (or is there a problem 
with that?).

> \ No newline at end of file
...

> +    if (windows.empty())
> +    {
> +        // we should be empty at this point...
> +        // emit a warning and clean the list.
> +        kDebug() << "Windows list not empty. Left items : " <<
> windows.count(); 

 if( ! ... ?

> +    // We need to mark the screen windows as transformed. Otherwise the
> whole
> +    // screen won't be repainted, resulting in artefacts.
> +    // Could we just set a subset of the screen to be repainted ? 

 Yes, you can modify ScreenPrePaintData to extend what will be painted.

> and what is missing is some text 
> translation (I don't know how some phisical properties in english)

 Me probably neither, but you can try asking here anyway.

> and a good config dialog (the defaut parameters are sane, but if you try to
> trick them manually, you may broke the effect...)
> If the config dialog is not finished for 4.1, we can simply disable it.

 A good config dialog is probably something with a wooble-less/wobble-more 
slider and perhaps little more, with the rest having good defaults; the 
current one belongs in advanced, if at all. I understand doing all these 
values and figuring out the right values must have been quite some work, but 
I mean, what is 'Mean with Median' and who's going to set it?

> If you are ok, I'll commit the code as soon as possible and update the
> feature plan for 4.1

 Looks ok to me.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]