[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: A trivial patch to the shadow plugin for colorable shadows
From: Rivo Laks <rivolaks () hot ! ee>
Date: 2008-04-01 18:44:28
Message-ID: 200804012144.28939.rivolaks () hot ! ee
[Download RAW message or body]
Ühel kenal päeval (teisipäev 01 aprill 2008) kirjutas Louai Al-Khanji:
> On Tue, Apr 1, 2008 at 5:27 PM, Rivo Laks <rivolaks@hot.ee> wrote:
> > Ühel kenal päeval (teisipäev 01 aprill 2008) kirjutas Louai Al-Khanji:
> > > Right, I got a bit sidetracked, sorry it took this long :) Attached is
> > >
> > > a proposed patch which I've been testing for a while. Comments?
> > > Objections? If not, I'll commit by the end of the week.
> >
> > What about adding two static methods to the ShadowEffect class instead
> > of the (IMHO ugly) _helper.h file?
> >
> > Rivo
>
> The thing is that the code is needed both in the config code and the
> effect code. How would that work? I think it's ugly too but couldn't
> figure out a better way to do this.
You could #include "shadow.h" in shadow_config.cpp, no?
Rivo
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic