[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Trouble with fade out
From:       Rivo Laks <rivolaks () hot ! ee>
Date:       2008-03-03 19:21:46
Message-ID: 200803032121.47079.rivolaks () hot ! ee
[Download RAW message or body]

Ühel kenal päeval (esmaspäev, 3. märts 2008) kirjutas Eike Hein:
> Lubos Lunak wrote:
> >  The patch looks correct. The docs for XShapeGetRectangles() mention
> > returning NULL only if shape is not present, so using the full rectangle
> > in that case made sense to me. Returning NULL when the count is zero is
> > as lame as malloc(0) returning NULL :(.
>
> The patch indeed fixes the problem for me (yay!). That said,
> I could also change the animation so that it moves directly
> from the next-to-last frame to calling hide(), i.e. call it
> when the mask isn't fully empty yet. In fact, I was under
> the impression I was already doing that, but I guess there's
> an off-by-one in the logic there. If the patch makes sense
> I guess it should go in anyway, though.

I committed the patch as well as backported it to 4.0 branch.

Rivo
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]