On po 11. února 2008, Rivo Laks wrote:
> Ühel kenal päeval (esmaspäev 11 veebruar 2008) kirjutas Lubos Lunak:
> >  Yes. Either its the whole screen, or the (often one) changed regions. If
> > there are more places that need updates the code could even optimize the
> > region similarly to SceneOpenGL::Texture::optimizeBindDamage().
>
> Are you sure we could do region optimization there? Wouldn't it cause
> problems if we use e.g. bounding rect of the clip region and thus paint
> outside the actual clip region?

 Ah, right. But the place setting up the clipping could possibly do this, 
unless that exact clipping is required. Well, this can wait if we really need 
it.

> > > So in that sense it shouldn't actually have
> > > any performance impact as long as the effects aren't using it.
> >
> >  When talking about performance I was mostly wondering about the overhead
> > of the extra clipping. There are additional OpenGL calls with this patch
> > that aren't there now.
>
> Calling glScissor() shouldn't have that much overhead. The minor state
> switches shouldn't be too bad either. I'm not completely sure but I think
> compared to the rest of our rendering code, the introduced overhead should
> be minor.

 Ok. Committed.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin