[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: KDE/kdebase/workspace/kwin/clients/oxygen
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2007-10-10 15:12:42
Message-ID: feiq5a$777$1 () sea ! gmane ! org
[Download RAW message or body]

Lubos Lunak wrote:
> On Wednesday 10 of October 2007, Matthew Woehlke wrote:
>> Lubos Lunak wrote:
>>> On Monday 10 of September 2007, Matthew Woehlke wrote:
>>>> SVN commit 710741 by mwoehlke:
>>>>
>>>> Set palette's currentColorGroup since apparently kwin doesn't give us
>>>> one with the right color group. This fixes the bug where the oxygen
>>>> windeco always uses the inactive colors. Is this something that can be
>>>> fixed in kwin?
>>> ...
>>>
>>>>      QPalette palette = widget()->palette();
>>>>      QPainter painter(widget());
>>>>
>>>> +    // ### - This feels like a kwin bug; the palette we get back always
>>>> seems +    // to be (incorrectly) using the Inactive group, which is
>>>> wrong; active +    // windows should have currentColorGroup() == Active.
>>>> So, hack around it... +    // I don't think a window can be disabled?
>>>> +    if (isActive())
>>>> +        palette.setCurrentColorGroup(QPalette::Active);
>>>> +    else
>>>> +        palette.setCurrentColorGroup(QPalette::Inactive);
>>>> +
>>>>      QRect title(titlebar_->geometry());
>>>  That's not a bug, technically. You're asking for the palette of the
>>> decoration's widget. Since KWin itself is never the active application,
>>> the widget can never be active.
>> That's arguable. IMO it makes sense that the palette for the windeco to
>> use the same state as the window it belongs to. Otherwise the palette
>> used to draw the deco is not the palette used to draw the window, and it
>> is necessary to manually change the palette's currentColorGroup, as in
>> this patch, and the second one I just had to commit for the same problem.
> 
>  Ok. Feel free to send a patch.

Ok, cool, I'll put this on my TODO list then and try to get you 
something by Friday... shouldn't be very invasive. Thanks :-).

-- 
Matthew
If you can read this, you're too close.

_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]