[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Effects and window rendering
From:       Rivo Laks <rivolaks () hot ! ee>
Date:       2007-04-28 13:05:04
Message-ID: 200704281605.04691.rivolaks () hot ! ee
[Download RAW message or body]

Ühel kenal päeval (laupäev 28 aprill 2007) kirjutas Lubos Lunak:
> On so 28. dubna 2007, Rivo Laks wrote:
> > Patch is attached. I tested with DesktopGrid and few other effects and
> > they're all working well.
> > Ok to commit?
>
>  Ok.

Committed

> > >  I think the post calls could be removed, now that the resetting is
> > > done at the very beginning. Most post calls are really only used to
> > > triggering next repaint, with the exception of
> > > TaskbarThumbnailEffect::postPaintScreen(), which should paint the
> > > thumbnails in paintScreen() and not here, and
> > > VideoRecordEffect::postPaintScreen(), which also could grab the screen
> > > contents after calling next effect's paintScreen().  Making them to be
> > > last would be achieved by having them first in the effects order.
> >
> > Dunno, maybe there will be some use for them in the future. And we need
> > them until there's support for real effect ordering anyway (opposed to
> > ATM's order is order of loading). So I won't remove them yet.
>
>  But the order of loading now is the real ordering, if you want a specific
> order you need to rearrange the effect in the config file the way you want.
> It'll of course just somewhen need some support for specifying a
> recommended order. However the post calls reorder can wait for the time
> when the API is finalized, I'll just note it down for now.

Rearrange: that's what I meant with "real ordering" ;-)

Rivo
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]