On Monday 09 of April 2007, Rivo Laks wrote:
> Updated patch is attached.

 Looks good, please commit.

 Since the classes in kwineffects.h are kind of like interface API, I think 
there shouldn't be any internals in those classes and that they should be 
moved to the *Impl classes. Specifically, everything in EffectsHandler 
starting with startPaint() is internal and should not be there 
(compositingType() being an exception). But this can be done after the 
commit, I don't want to risk any conflicts by waiting.

> Both PresentWindows and Shadow effects are now 
> put into single plugin kwin4_effects_builtins (yeah, the name sucks).

 Nevermind, it's ok. I'm bad at names too :).

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin