From kwin Tue Apr 10 12:12:09 2007 From: Lubos Lunak Date: Tue, 10 Apr 2007 12:12:09 +0000 To: kwin Subject: Re: Effects as plugins Message-Id: <200704101412.09686.l.lunak () suse ! cz> X-MARC-Message: https://marc.info/?l=kwin&m=117620687120459 On Monday 09 of April 2007, Rivo Laks wrote: > Updated patch is attached. Looks good, please commit. Since the classes in kwineffects.h are kind of like interface API, I think there shouldn't be any internals in those classes and that they should be moved to the *Impl classes. Specifically, everything in EffectsHandler starting with startPaint() is internal and should not be there (compositingType() being an exception). But this can be done after the commit, I don't want to risk any conflicts by waiting. > Both PresentWindows and Shadow effects are now > put into single plugin kwin4_effects_builtins (yeah, the name sucks). Nevermind, it's ok. I'm bad at names too :). -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Lihovarska 1060/12 tel: +420 284 028 972 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http//www.suse.cz _______________________________________________ Kwin mailing list Kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin