From kwin Mon Oct 13 17:47:52 2003 From: Koos Vriezen Date: Mon, 13 Oct 2003 17:47:52 +0000 To: kwin Subject: Re: [Kwin] Re: Embedding multible java applets and focus problems X-MARC-Message: https://marc.info/?l=kwin&m=106606774009676 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--0-475131505-1066067194=:55544" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-475131505-1066067194=:55544 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: <20031013194721.O55544@xs1.xs4all.nl> On Mon, 13 Oct 2003, Lubos Lunak wrote: > On Monday 13 of October 2003 18:15, Koos Vriezen wrote: > > On Mon, 13 Oct 2003, Lubos Lunak wrote: > [snip] > > > > If ReparentNotify is a guaranteed event, I think second patch is > > > > preferable (might make QApplication::syncX() not needed any more ... > > > > yes work like before). > > > > > > ReparentNotify is a guaranteed event, you'll get it after doing > > > XReparentWindow() into the embedder. However, given my comment above, > > > wouldn't it be simpler to add 'if( w == window ) return;' at the top of > > > embed()? > > > > My first thought too, but ReparentNotify does > > window = e->xreparent.window; > > embed( window ); > > and assuming this code is there for a good reason, I made those two > > alternative patches. > > Aha, I haven't noticed this. Well, as I've already said, more comments > wouldn't hurt. I'd support Leon's idea of splitting embed() then. Ok, attached what might be a beginning of this split. To prevent flashing windows after closing konqueror, both java and nsplugin should call destroyWithParent(true) on the qxembed widget. [..] > That patch is to blame only for the taskbar entry blinking. But Konqueror > HEAD doesn't work, regardless of the window manager - it doesn't work with > KWin HEAD, KWin from 3.1, Metacity or FVWM2, so don't blame it on KWin. But I > have no idea who to blame instead. Hmm, probably khtml I guess. Previewing an applet in konqueror (by adding the appletviewer as the embedded viewer for x-java) does get the focus right indeed... Koos --0-475131505-1066067194=:55544 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="qxembed.diff" Content-Transfer-Encoding: BASE64 Content-ID: <20031013194634.D55544@xs1.xs4all.nl> Content-Description: Content-Disposition: ATTACHMENT; FILENAME="qxembed.diff" SW5kZXg6IHF4ZW1iZWQuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS Q1MgZmlsZTogL2hvbWUva2RlL2tkZWxpYnMva2RldWkvcXhlbWJlZC5jcHAs dg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjQ0DQpkaWZmIC11IC0zIC1wIC1y MS40NCBxeGVtYmVkLmNwcA0KLS0tIHF4ZW1iZWQuY3BwCTI1IFNlcCAyMDAz IDE4OjE2OjU0IC0wMDAwCTEuNDQNCisrKyBxeGVtYmVkLmNwcAkxMyBPY3Qg MjAwMyAxNzozMjowMSAtMDAwMA0KQEAgLTk4LDYgKzk4LDcgQEAgcHVibGlj Og0KICAgICBRWEVtYmVkRGF0YSgpeyANCiAgICAgICAgIGF1dG9EZWxldGUg PSB0cnVlOw0KICAgICAgICAgeHBsYWluID0gZmFsc2U7DQorICAgICAgICBk ZXN0cm95V2l0aFBhcmVudCA9IGZhbHNlOw0KICAgICAgICAgeGdyYWIgPSBm YWxzZTsNCiAgICAgICAgIGxhc3RQb3MgPSBRUG9pbnQoMCwwKTsNCiAgICAg fQ0KQEAgLTEwNiw2ICsxMDcsNyBAQCBwdWJsaWM6DQogICAgIA0KICAgICBi b29sIGF1dG9EZWxldGU7DQogICAgIGJvb2wgeHBsYWluOw0KKyAgICBib29s IGRlc3Ryb3lXaXRoUGFyZW50Ow0KICAgICBib29sIHhncmFiOw0KICAgICBR V2lkZ2V0KiBmb2N1c1Byb3h5Ow0KICAgICBRUG9pbnQgbGFzdFBvczsNCkBA IC03MzUsNyArNzM3LDggQEAgdm9pZCBRWEVtYmVkOjplbWJlZChXSWQgdykN CiAgICAga2REZWJ1ZygpIDw8ICIqKioqKioqKioqKioqKioqKioqKioqKioq KiBFbWJlZCAiPDwgUVN0cmluZygiMHglMSIpLmFyZyh3LCAwLCAxNikgPDwg IiBpbnRvICIgPDwgUVN0cmluZygiMHglMSIpLmFyZyh3aW5JZCgpLCAwLCAx NikgPDwgIiB3aW5kb3c9IiA8PCBRU3RyaW5nKCIweCUxIikuYXJnKHdpbmRv dywgMCwgMTYpIDw8ICIgKioqKioqKioqKiIgPDwgZW5kbDsgDQogICAgIGlm ICghdykNCiAgICAgICAgIHJldHVybjsNCi0gICAgWEFkZFRvU2F2ZVNldCgg cXRfeGRpc3BsYXkoKSwgdyApOw0KKyAgICBpZiAoIWQtPmRlc3Ryb3lXaXRo UGFyZW50KQ0KKyAgICAgICAgWEFkZFRvU2F2ZVNldCggcXRfeGRpc3BsYXko KSwgdyApOw0KICAgICBib29sIGhhc193aW5kb3cgPSAgdyA9PSB3aW5kb3c7 DQogICAgIHdpbmRvdyA9IHc7DQogICAgIGlmICggIWhhc193aW5kb3cgKSB7 DQpAQCAtNzU4LDcgKzc2MSw4IEBAIHZvaWQgUVhFbWJlZDo6ZW1iZWQoV0lk IHcpDQogICAgICAgICAgICAga2REZWJ1ZygpIDw8IFFTdHJpbmcoIj4+PiBM b29wICUxOiByZXBhcmVudCBvZiAweCUyIGludG8gMHglMyBmYWlsZWQiKS5h cmcoaSkuYXJnKHcsIDAsIDE2KS5hcmcod2luSWQoKSwgMCwgMTYpIDw8IGVu ZGw7DQogICAgICAgICAgICAgVVNMRUVQKDEwMDApOw0KICAgICAgICAgfQ0K LSAgICAgICAgUUFwcGxpY2F0aW9uOjpzeW5jWCgpOw0KKyAgICAgICAgLy9R QXBwbGljYXRpb246OnN5bmNYKCk7DQorICAgICAgICByZXR1cm47IC8vIGxl dHMgUmVwYXJlbnROb3RpZnkgZmluaXNoIHRoZSBqb2INCiAgICAgfQ0KIA0K ICAgICBYUmVzaXplV2luZG93KHF0X3hkaXNwbGF5KCksIHcsIHdpZHRoKCks IGhlaWdodCgpKTsNCkBAIC03OTMsNiArNzk3LDEzIEBAIFdJZCBRWEVtYmVk OjplbWJlZGRlZFdpbklkKCkgY29uc3QNCiAgICAgcmV0dXJuIHdpbmRvdzsN CiB9DQogDQorLyoNCisgKiBTZXRzIHRoZSB1c2Ugb2YgWEFkZFRvU2F2ZVNl dCBjYWxsIGluIGVtYmVkKCkNCisgKi8NCit2b2lkIFFYRW1iZWQ6OmRlc3Ry b3lXaXRoUGFyZW50KGJvb2wgYikNCit7DQorICAgIGQtPmRlc3Ryb3lXaXRo UGFyZW50ID0gYjsNCit9DQogDQogLyohXHJlaW1wDQogICovDQpJbmRleDog cXhlbWJlZC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTog L2hvbWUva2RlL2tkZWxpYnMva2RldWkvcXhlbWJlZC5oLHYNCnJldHJpZXZp bmcgcmV2aXNpb24gMS4yMQ0KZGlmZiAtdSAtMyAtcCAtcjEuMjEgcXhlbWJl ZC5oDQotLS0gcXhlbWJlZC5oCTIxIEF1ZyAyMDAzIDA5OjUxOjM3IC0wMDAw CTEuMjENCisrKyBxeGVtYmVkLmgJMTMgT2N0IDIwMDMgMTc6MzI6MDIgLTAw MDANCkBAIC0xMzYsNiArMTM2LDEzIEBAIHB1YmxpYzoNCiAgICAgV0lkIGVt YmVkZGVkV2luSWQoKSBjb25zdDsNCiANCiAgICAgLyoqDQorICAgICAqIERl ZmF1bHQgdGhlIGVtYmVkZGVkIHdpbmRvdyBpcyByZXBhcmVudGVkIHRvIHRo ZSByb290IHdpbmRvdyB3aGVuDQorICAgICAqIHRoaXMgd2lkZ2V0IGdldHMg ZGVsZXRlZC4NCisgICAgICogQ2FsbGluZyBkZXN0cm95V2l0aFBhcmVudCh0 cnVlKSwgZGVzdHJveXMgdGhlIGVtYmVkZGVkIHdpbmRvdw0KKyAgICAgKiov DQorICAgIHZvaWQgZGVzdHJveVdpdGhQYXJlbnQoIGJvb2wgPSB0cnVlICk7 DQorDQorICAgIC8qKg0KICAgICAgKiBBIGZ1bmN0aW9uIGZvciBjbGllbnRz IHRoYXQgZW1iZWQgdGhlbXNlbHZlcy4gVGhlIHdpZGdldA0KICAgICAgKiBj bGllbnQgd2lsbCBiZSBlbWJlZGRlZCBpbiB0aGUgd2luZG93IHdpbmRvdy4g VGhlIGFwcGxpY2F0aW9uIGhhcw0KICAgICAgKiB0byBlbnN1cmUgdGhhdCB3 aW5kb3cgaXMgdGhlIGhhbmRsZSBvZiB0aGUgd2luZG93IGlkZW50aWZpZXIg b2YNCg== --0-475131505-1066067194=:55544 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kwin mailing list Kwin@mail.kde.org http://mail.kde.org/mailman/listinfo/kwin --0-475131505-1066067194=:55544--