[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: [Kwin] Fwd: [RFC][PATCH] kwin/workspace: don't force new placement after moving to different des
From:       Cristian Tibirna <tibirna () kde ! org>
Date:       2002-08-30 12:26:22
[Download RAW message or body]

On Friday, 30 August 2002 05:47, Lubos Lunak wrote:
>  I actually agree here. Cristian?
>

I don't, but I understand the concerns raised.

My problem with keeping old placement when moving window to a new desktop is 
that, 90% os cases (at least on my computer), the window I was moving was 
ending up in a place where there already was a window (obvious: moving to 
another desktop a window that was initially placed at (0,0) puts that window 
at the same place as the first placed window on the destination desktop). And 
since selecting the new desktop gives the focus to  (and eventually raises) 
the window that had focus on that desktop when last we visited it, the newly 
moved window almost always ends up covered underneath. And IMNSHO, _this_ 
comes with a bigger factor of surprise ("where's my window??").

I realise, though, that I should have done it only if smart placement is 
activated and eventually save a state by client saying if that client was 
moved by hand or not, and check that before re-place()-ing the client on 
desktop change (altough even after the user moved it by hand, this doesn't 
want to say anything about where the window will... disappear).

Anyways, I added that patch following only my own usage experience and only 
after I was annoyed for months in a row by the ill behavior. But since it 
might be only me.... you can remove that. I will make an automatic script 
that will patch kwin on my machine.

Comments that compare my work with microsoft always annoy me though, and I 
find them rude and uncalled for, for obvious reasons (one doesn't pay 500$ 
per year to use my work, one has my attention when offering opinion about my 
code, the code is there for everybody to see/change/improve).

> ----------  Forwarded Message  ----------
>
> Subject: [RFC][PATCH] kwin/workspace: don't force new placement after
> moving to different desktop
> Date: Fri, 30 Aug 2002 11:21:35 +0200
> From: Melchior FRANZ <a8603365@unet.univie.ac.at>
> To: kde-core-devel@kde.org
>
> What bugs me since a while is, that kwin destroys my deliberate window
> placement, when I move a window to another desktop. There's a comment in
>
> workplace:
> | the old position is most probably inappropriate on the new desktop
> | thus we place the client again, before we show it, [...]
>
> but IMHO that's wrong. Why should the window placement that was OK for
> the current desktop suddenly be inappropriate on another desktop? Either
> it was still KDE's original placement, anyway, or it got meanwhile changed
> by the user. Either way, I can't imagine a case where it would be
> desirable to change the placement while moving to another desktop.
> That's ignoring the user's will and contradicts the "least surprise
> paradigm". It reminds too much of Windows or other systems that try
> to be wiser than the user.  :->
>
> Hence I suggest to apply the following patch:
>
> m.
>
>
>
> RCS file: /cvs/kdebase/kwin/workspace.cpp,v
> retrieving revision 1.357
> diff -u -3 -p -r1.357 workspace.cpp
> --- workspace.cpp       2002/08/28 15:17:29     1.357
> +++ workspace.cpp       2002/08/30 09:21:19
> @@ -2996,10 +2996,6 @@ void Workspace::sendClientToDesktop( Cli
>      c->setDesktop( desk );
>      if( desk == NETWinInfo::OnAllDesktops )
>          c->setSticky( true );
> -    else
> -        //CT 01Jul2002 - the old position is most probably inappropriate
> on the new desktop -        //    thus we place the client again, before we
> show it, but only if it's not OnAllDesktops -        place(c);
>
>      if ( c->isOnDesktop( currentDesktop() ) ) {
>          c->show();
>
> -------------------------------------------------------

-- 
Cristian Tibirna .. tibirna@sympatico.ca
PhD student .. ctibirna@giref.ulaval.ca .. www.giref.ulaval.ca/~ctibirna
KDE developer .. tibirna@kde.org .. www.kde.org

_______________________________________________
Kwin mailing list
Kwin@mail.kde.org
http://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]