[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kvm-ppc
Subject:    Re: [PATCH v2] powerpc: kvm: optimize "sc 1" as fast return
From:       liu ping fan <qemulist () gmail ! com>
Date:       2013-11-18 1:06:54
Message-ID: CAJnKYQnr5J5kEkj4YVnUYXa=vcU2qcLP9MNVXqXqKO6Qx5bMVg () mail ! gmail ! com
[Download RAW message or body]

On Sat, Nov 16, 2013 at 3:00 PM, Paul Mackerras <paulus@samba.org> wrote:
> On Fri, Nov 15, 2013 at 04:35:01PM +0800, Liu Ping Fan wrote:
>>
>> +sc_1_fast_return:
>> +     mtspr   SPRN_SRR0,r10
>> +     mtspr   SPRN_SRR1,r11
>> +     li      r10, BOOK3S_INTERRUPT_SYSCALL
>> +     li      r11, (MSR_ME << 1) | 1  /* synthesize MSR_SF | MSR_ME */
>> +     rotldi  r11, r11, 63
>
> You need a "mr r4, r9" instruction here, because fast_guest_return
> needs the vcpu pointer in r4.  Apart from that this looks fine.
>
Will fix it.

Thanks and regards,
Pingfan
>> +     b       fast_guest_return
>
> Paul.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]