[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kvm
Subject:    Re: [PATCH] KVM: x86: Remove IA32_PERF_GLOBAL_OVF_CTRL from KVM_GET_MSR_INDEX_LIST
From:       Sean Christopherson <seanjc () google ! com>
Date:       2023-11-30 20:58:27
Message-ID: ZWj3c1ho7CKMsHLn () google ! com
[Download RAW message or body]

On Mon, Nov 13, 2023, Jim Mattson wrote:
> This MSR reads as 0, and any host-initiated writes are ignored, so
> there's no reason to enumerate it in KVM_GET_MSR_INDEX_LIST.

This looks sane to me, but I'd like to get a thumbs up from Paolo before applying.
AFAICT, this won't cause problems for QEMU, but a sanity check from someone that
runs a different VMM than us would be nice to have.

> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
>  arch/x86/kvm/x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 2c924075f6f1..54bcc197b314 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1470,7 +1470,7 @@ static const u32 msrs_to_save_pmu[] = {
>  	MSR_ARCH_PERFMON_FIXED_CTR0, MSR_ARCH_PERFMON_FIXED_CTR1,
>  	MSR_ARCH_PERFMON_FIXED_CTR0 + 2,
>  	MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_CORE_PERF_GLOBAL_STATUS,
> -	MSR_CORE_PERF_GLOBAL_CTRL, MSR_CORE_PERF_GLOBAL_OVF_CTRL,
> +	MSR_CORE_PERF_GLOBAL_CTRL,
>  	MSR_IA32_PEBS_ENABLE, MSR_IA32_DS_AREA, MSR_PEBS_DATA_CFG,
>  
>  	/* This part of MSRs should match KVM_INTEL_PMC_MAX_GENERIC. */
> -- 
> 2.43.0.rc0.421.g78406f8d94-goog
> 

[prev in list] [next in list] [prev in thread] [next in thread]