[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kvm
Subject:    Re: [GIT PULL 09/11] KVM: s390: add bitmap for handling cpu-local interrupts
From:       Christian Borntraeger <borntraeger () de ! ibm ! com>
Date:       2014-11-29 21:05:10
Message-ID: 547A3506.1080908 () de ! ibm ! com
[Download RAW message or body]

Am 28.11.2014 um 18:18 schrieb Paolo Bonzini:
> 
> 
> On 28/11/2014 14:25, Christian Borntraeger wrote:
> > 
> > +struct kvm_s390_irq_payload {
> > +	struct kvm_s390_io_info io;
> > +	struct kvm_s390_ext_info ext;
> > +	struct kvm_s390_pgm_info pgm;
> > +	struct kvm_s390_emerg_info emerg;
> > +	struct kvm_s390_extcall_info extcall;
> > +	struct kvm_s390_prefix_info prefix;
> > +	struct kvm_s390_mchk_info mchk;
> > +};
> > +
> 
> struct or union?

struct. This is used for keeping the payload of the interrupts. Multiple different \
interrupts can be pending and most of them have payload - we want to keep everything.

Now, looking at that code again, as I/O is floating and emergency is also handled via \
a separate bitmap we could get rid of these two in a follow-up patch. Jens, can you \
have a look and prepare a followup-cleanup if appropriate? Christian

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]