[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kvm
Subject:    Re: [RFC PATCH v1 3/5] KVM: Add paravirt kvm_flush_tlb_others
From:       Avi Kivity <avi () redhat ! com>
Date:       2012-04-29 12:23:16
Message-ID: 4F9D32B4.8040002 () redhat ! com
[Download RAW message or body]

On 04/27/2012 07:24 PM, Nikunj A. Dadhania wrote:
> flush_tlb_others_ipi depends on lot of statics in tlb.c.  Replicated
> the flush_tlb_others_ipi as kvm_flush_tlb_others to further adapt to
> paravirtualization.
>
> Use the vcpu state information inside the kvm_flush_tlb_others to
> avoid sending ipi to pre-empted vcpus.
>
> * Do not send ipi's to offline vcpus and set flush_on_enter flag

get_user_pages_fast() depends on the IPI to hold off page table teardown
while they are locklessly walked with interrupts disabled.  If a vcpu
were to be preempted while in this critical section, another vcpu
tearing down page tables would go ahead and destroy them.  when the
preempted vcpu resumes it then touches the freed pages.

We could try to teach kvm and get_user_pages_fast() about this, but this
is intrusive.  Another option is to replace the cpu_relax() loop with
something that sleeps and is then woken up by the TLB IPI handler if needed.

> * For online vcpus: Wait for them to clear the flag
>
>

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]