[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kvm
Subject:    Re: [PATCH] KVM: Emulator: Opcode 0x80 gets a byte immediate
From:       Gleb Natapov <gleb () redhat ! com>
Date:       2012-04-29 8:22:33
Message-ID: 20120429082233.GX15413 () redhat ! com
[Download RAW message or body]

On Fri, Apr 27, 2012 at 05:23:36PM +0300, Nadav Amit wrote:
> The single byte opcode 0x80 should get a byte immediate.
> The previous emulation is broken for opcode 0x80.
It is not. That what ByteOp is about.

> ---
>  arch/x86/kvm/emulate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 8375622..dd53e53 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -3464,7 +3464,7 @@ static struct opcode opcode_table[256] = {
>  	/* 0x70 - 0x7F */
>  	X16(D(SrcImmByte)),
>  	/* 0x80 - 0x87 */
> -	G(ByteOp | DstMem | SrcImm | ModRM | Group, group1),
> +	G(ByteOp | DstMem | SrcImmByte | ModRM | Group, group1),
>  	G(DstMem | SrcImm | ModRM | Group, group1),
>  	G(ByteOp | DstMem | SrcImm | ModRM | No64 | Group, group1),
>  	G(DstMem | SrcImmByte | ModRM | Group, group1),
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]