[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kvm
Subject:    Re: [PATCH 13/21] Remove virtio-console PIF change
From:       Avi Kivity <avi () redhat ! com>
Date:       2009-04-30 9:40:39
Message-ID: 49F97217.3080206 () redhat ! com
[Download RAW message or body]

Anthony Liguori wrote:
> If this change should happen, it should happen in upstream QEMU.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  hw/virtio-console.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-console.c b/hw/virtio-console.c
> index 89e8be0..b263281 100644
> --- a/hw/virtio-console.c
> +++ b/hw/virtio-console.c
> @@ -132,7 +132,7 @@ void *virtio_console_init(PCIBus *bus, CharDriverState *chr)
>                                           PCI_DEVICE_ID_VIRTIO_CONSOLE,
>                                           PCI_VENDOR_ID_REDHAT_QUMRANET,
>                                           VIRTIO_ID_CONSOLE,
> -                                         PCI_CLASS_OTHERS, 0x00,
> +                                         PCI_CLASS_DISPLAY_OTHER, 0x00,
>                                           0, sizeof(VirtIOConsole));
>      if (s == NULL)
>          return NULL;
>   

Since virtio-console is not enabled by default, it isn't needed, so I'll 
apply this.

But if it were needed, there's no reason to introduce regressions into 
qemu-kvm.git.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]