[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ktexteditor-devel
Subject:    Patch for review
From:       Hamish Rodda <rodda () kde ! org>
Date:       2007-10-25 13:30:54
Message-ID: 200710252330.57306.rodda () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,

Could someone please look at the attached patch.  It fixes a logic error in 
SmartRange::setInsertBehaviour(), where I had accidentally reversed the 
setting.  ExpandLeft is meant to encapsulate any characters inserted at the 
start of the range, and to do that you need to make the start cursor not move 
on insert.

Thanks,
Hamish

["ktexteditor-fixrangebehavior.patch" (text/x-diff)]

Index: smartrange.cpp
===================================================================
--- smartrange.cpp	(revision 728771)
+++ smartrange.cpp	(working copy)
@@ -305,7 +305,7 @@
 
 void SmartRange::setInsertBehavior(SmartRange::InsertBehaviors behavior)
 {
-  static_cast<SmartCursor*>(m_start)->setInsertBehavior((behavior & ExpandLeft) ? \
SmartCursor::MoveOnInsert : SmartCursor::StayOnInsert); +  \
static_cast<SmartCursor*>(m_start)->setInsertBehavior((behavior & ExpandLeft) ? \
SmartCursor::StayOnInsert : SmartCursor::MoveOnInsert);  \
static_cast<SmartCursor*>(m_end)->setInsertBehavior((behavior & ExpandRight) ? \
SmartCursor::MoveOnInsert : SmartCursor::StayOnInsert);  }
 


["signature.asc" (application/pgp-signature)]

_______________________________________________
KTextEditor-Devel mailing list
KTextEditor-Devel@kde.org
https://mail.kde.org/mailman/listinfo/ktexteditor-devel


[prev in list] [next in list] [prev in thread] [next in thread]