From ktexteditor-devel Sat Oct 15 11:10:58 2005 From: Hamish Rodda Date: Sat, 15 Oct 2005 11:10:58 +0000 To: ktexteditor-devel Subject: Re: To QString or to QStringList? Message-Id: <200510152111.00688.rodda () kde ! org> X-MARC-Message: https://marc.info/?l=ktexteditor-devel&m=112937726405416 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1240745591==" --===============1240745591== Content-Type: multipart/signed; boundary="nextPart3385593.e8D0AUjGYm"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart3385593.e8D0AUjGYm Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 15 October 2005 02:37, Christoph Cullmann wrote: > On Friday 14 October 2005 17:07, Hamish Rodda wrote: > > I'm told that many text editors work with large buffers which include t= he > > newline characters inline, but that's not the way kate works and i doubt > > we'd be changing it. Perhaps if another editor was to implement the > > ktexteditor interface, it would be more efficient for them to go with t= he > > plain QString version... > > I have 2 problems with stringlists: > - what if the strings inside them contain linebreaks? how to handle this? A few options: * we remove them (probably my preferred option) * we add a second line (ie. mixed QStringLists and '\n') * we make the behaviour undefined > - is that really convenient for normal usage? if you insert a blob of > text, atm it's easy (at least of the splitting works), later, each client > app needs to split the lines itself, don't think that makes life much > easier for app devs QString blob =3D getBlob(); setText(blob.split('\n')); but still, I think keeping at least the setText(QString) function makes sen= se=20 =2D for large strings which haven't already been split, it's faster. Perhaps we should provide both? I've committed what I've done (because I had lots more changes as well), so= =20 take a look... easy to remove if we decide against it. Cheers, Hamish. --nextPart3385593.e8D0AUjGYm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBDUOPEH8BtnSmIlUYRApsiAJwJOHLIMsf9hoIHSi95xxnvZ0FmmgCgs8ln ETx+NxIMiOfDwk9Q0ui+Kjo= =ZRxu -----END PGP SIGNATURE----- --nextPart3385593.e8D0AUjGYm-- --===============1240745591== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ktexteditor-devel mailing list Ktexteditor-devel@kde.org https://mail.kde.org/mailman/listinfo/ktexteditor-devel --===============1240745591==--