[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ktexteditor-devel
Subject:    KDocument::View vs. KTE::View
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2005-09-17 13:46:23
Message-ID: 200509171546.23361.dhdev () gmx ! de
[Download RAW message or body]

Hi,

1) Duplicate signals
KDocument::View has signals
  void focusIn ( KDocument::View *view );
  void focusOut ( KDocument::View *view );
  void informationMessage ( KDocument::View *view, const QString &message );

KTextEditor::View has signals
  void focusIn ( KTextEditor::View *view );
  void focusOut ( KTextEditor::View *view );
  void informationMessage ( KTextEditor::View *view, const QString &message );

Isn't that to be merged?
Only disadvantange for kate part is connected slots need more casting,
i.e. from KDocument::View to KTE::View.

2) KDocument::View does not provide an accessor to get the document
   it operates on. Shouldn't
     virtual Document *KTextEditor::View::document () = 0;
   be moved to KDocument::View?

The casting stuff applies again :)


As I don't have a compilable checkout right now I can't test if my changes
would compile, so can anybody have a look at this?

cu
-- 
Dominik
_______________________________________________
Ktexteditor-devel mailing list
Ktexteditor-devel@kde.org
https://mail.kde.org/mailman/listinfo/ktexteditor-devel

[prev in list] [next in list] [prev in thread] [next in thread]