[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: Kstars 3.6.0 MacOS find Object crash
From: Akarsh Simha <akarshsimha () gmail ! com>
Date: 2022-08-20 18:14:12
Message-ID: CA+9k5txYkjd6w3LSeEOW01uYCjKOoXMCCko5LXEUpt5CP7PPxw () mail ! gmail ! com
[Download RAW message or body]
Bravissimo! This is some very patient analysis on your part Robert. I was
very nervous when introducing concurrency in the find dialog because
concurrency just makes things so much harder to debug and stuff. I'm
strapped for time for the next few months, so I don't know when I can look
at it, but the moment I can I'll see if I missed something in the QThread
API. If anyone knows a lot about Qt's concurrency framework, I'd be
grateful if they could take a look.
On Fri, Aug 19, 2022 at 22:01 Robert Lancaster <rlancaste@gmail.com> wrote:
> Hey guys,
>
>
> Ok, I dug into this and ran a bunch of tests. I don't know why this crash
> only occurs when running by double clicking the app and not by running from
> Terminal or QT Creator. It is very inconvenient to have an error that
> won't happen when you run the code in a debugger and then will happen every
> time if you don't! I had thought that maybe it was something with MacOS
> sandboxing or gatekeeper, or maybe it was something with packaging, or
> maybe it was something with environment variables. But as far as I could
> tell through my tests it is none of those. I printed the environments in a
> QMessagebox and they were slightly different, but not in any way that
> mattered I think. The packaging was not the culprit because it happened in
> the app both before and after packaging and I was running it on the same
> machine, so it should not be the issue. I haven't fully ruled out
> something with MacOS, but I don't currently think that is what it is since
> there was no error message or warning that pops up about the app being
> blocked from doing something it wasn't supposed to.
>
> So then I proceeded to experiment with the changes in that one Commit. I
> first tried narrowing down where the problem was by copying and pasting
> code from before or after the commit and testing. That let me rule out a
> lot of the commit. Then I added some Qmessagebox debug dialogs to see
> exactly when it would fail. As of now, it seems that the crash is entirely
> based on what happens when constructing the Find Dialog in find
> dialog.cpp. Specifically, it happens here:
>
> m_asyncDBManager(new CatalogsDB::AsyncDBManager(CatalogsDB::dso_db_path()))
>
>
> On line 65 when it constructs the new Asynch DB Manager. I did try
> changing the couple of lines of code in find dialog.cpp and find dialog.h
> so that it would use the old manager code from before this commit to verify
> if the new AsynchDBManger was really the culprit. And yes, it worked fine
> with the old code. So then I changed it back. Then I played around with
> the constructor for that class. Very strangely, I found that when I put my
> test QMessageBox message in just after line 772:
>
> m_thread->start();
>
>
> It didn't crash when it printed my debug QMessagebox but it did crash when
> I didn't have it there! That got me thinking that maybe for some reason,
> this object needed a little more time in its constructor for some reason,
> even though there are no more commands after that. So I just added a sleep
> command to see if that would serve the same purpose and it worked!
>
> QThread::msleep(100);
>
>
> So I would really like to know why this works. Here is a commit with a
> band aid for you guys to take a look at:
>
> https://invent.kde.org/education/kstars/-/merge_requests/706
>
> Thanks,
>
> Rob
>
>
> On Aug 17, 2022, at 2:06 AM, Jasem Mutlaq <mutlaqja@ikarustech.com> wrote:
>
> I received one report for Find Dialog crash as well on Raspberry Pi, so
> perhaps it's not unique to MacOS?
>
> However, I couldn't reproduce on Raspberry PI, Widows, or any x86-64
> machine.
>
> --
> Best Regards,
> Jasem Mutlaq
>
>
>
> On Wed, Aug 17, 2022 at 8:52 AM Robert Lancaster <rlancaste@gmail.com>
> wrote:
>
> > Ok I did some more testing.
> >
> > This commit is when the Find Dialog broke when running KStars on MacOS by
> > double clicking the app:
> >
> >
> > https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9
> >
> > I think that is the one you were hoping was not the one. I still don't
> > know why it broke it though. Every time I run it from terminal or qt
> > creator there is no problem. It is just when running it by double clicking
> > that is the problem.
> >
> > Note that I did test playing with the environment variables in qt creator
> > and that seemed to have no effect. And it also didn't seem to matter
> > whether kstars was packaged up or not, so it doesn't seem to be a packaging
> > issue.
> >
> > On Aug 16, 2022, at 2:11 PM, Akarsh Simha <akarshsimha@gmail.com> wrote:
> >
> > If I am to blame for this, the parallelism introduced in the asynchronous
> > find dialog is my suspect, rather than the comet regex (which was actually
> > Hy and not me). The regex seems unlikely to cause the erratic behavior
> > Robert is observing where it runs fine under a debugger.
> >
> > But if it works fine when running KStars from a command line, that
> > probably exonerates me and Hy, and is likely an environment issue like
> > Robert points out!
> >
> > Regards
> > Akarsh
> >
> >
> > On Tue, Aug 16, 2022 at 07:28 Robert Lancaster <rlancaste@gmail.com>
> > wrote:
> >
> > > Hey guys,
> > >
> > > I just got back from my two week trip to the Southwest. Yesterday I
> > > resolved the issue with building a dmg with my script, so now I can build
> > > DMGs that will work with older Macs and have all the features we want in
> > > the dmg.
> > >
> > > Next we can look into this Find Dialog bug. I did some experiments
> > > today and I found that if I run kstars from the command line or in a
> > > debugger, the find dialog works fine, but when running the app by double
> > > clicking it crashes when you first access the find dialog. This seems to
> > > me to indicate an environment issue, like maybe an issue with environment
> > > variables or maybe a link to a library that isn't properly in the app. I
> > > will check further.
> > >
> > > Thanks,
> > >
> > > Rob
> > >
> > > On Aug 13, 2022, at 6:09 AM, John Evans <john.e.evans.email@gmail.com>
> > > wrote:
> > >
> > > I have the same problem with 3.6.0. Crashes everytime the find object
> > > dialog is invoked (button, keyboard, etc.)
> > >
> > > Works great when I run it in debug in Qt though.
> > >
> > > Workaround is to use the skymap and click on the object you want. In
> > > the scheduler enter some text in the object field (doesn't matter what) and
> > > hit the + to use sky coordinates from the map.
> > >
> > > On Sat, 13 Aug 2022 at 10:05, Akarsh Simha <akarshsimha@gmail.com>
> > > wrote:
> > >
> > > >
> > > >
> > > > On Sat, Aug 13, 2022 at 01:27 Peter Amerl <pvamerl@gmail.com> wrote:
> > > >
> > > > > Hi All,
> > > > > Has anyone else experienced an immediate crash when searching for
> > > > > objects on a Mac using the Apple-f key combination?
> > > > > I can confirm that it has worked in the past without a crash. Neither
> > > > > Ctrl-f, nor selecting it from the menu appears to work for me at this time.
> > > > > The Crash trace is appended in the zip if anyone wants to have a look.
> > > > >
> > > >
> > > > Hi Peter
> > > >
> > > > When you say it worked in the past, could you provide the exact version
> > > > / git commit, and also your current version / git commit that has the bug?
> > > > I made several changes to the Find Dialog in the most recent version,
> > > > notably performing asynchronous database queries through another thread. It
> > > > never crashed on my Linux system. Also curious if someone else can
> > > > reproduce it on MacOS or if it is unique to your system.
> > > >
> > > > Regards
> > > > Akarsh
> > > >
> > > >
> > > > > Cheers,
> > > > > Peter
> > > > >
> > > > >
> > > > >
> > >
> >
>
[Attachment #3 (text/html)]
<div dir="auto">Bravissimo! This is some very patient analysis on your part Robert. I was very nervous \
when introducing concurrency in the find dialog because concurrency just makes things so much harder to \
debug and stuff. I'm strapped for time for the next few months, so I don't know when I can look at it, \
but the moment I can I'll see if I missed something in the QThread API. If anyone knows a lot about Qt's \
concurrency framework, I'd be grateful if they could take a look.</div><div \
dir="auto"><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 19, \
2022 at 22:01 Robert Lancaster <<a href="mailto:rlancaste@gmail.com">rlancaste@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
style="word-wrap:break-word;line-break:after-white-space"><div>Hey guys,</div><div><br></div><div> \
</div>Ok, I dug into this and ran a bunch of tests. I don't know why this crash only occurs when \
running by double clicking the app and not by running from Terminal or QT Creator. It is very \
inconvenient to have an error that won't happen when you run the code in a debugger and then will happen \
every time if you don't! I had thought that maybe it was something with MacOS sandboxing or gatekeeper, \
or maybe it was something with packaging, or maybe it was something with environment variables. But as \
far as I could tell through my tests it is none of those. I printed the environments in a QMessagebox \
and they were slightly different, but not in any way that mattered I think. The packaging was not the \
culprit because it happened in the app both before and after packaging and I was running it on the same \
machine, so it should not be the issue. I haven't fully ruled out something with MacOS, but I don't \
currently think that is what it is since there was no error message or warning that pops up about the app \
being blocked from doing something it wasn't supposed to.<div><br></div><div>So then I proceeded to \
experiment with the changes in that one Commit. I first tried narrowing down where the problem was by \
copying and pasting code from before or after the commit and testing. That let me rule out a lot of the \
commit. Then I added some Qmessagebox debug dialogs to see exactly when it would fail. As of now, it \
seems that the crash is entirely based on what happens when constructing the Find Dialog in find \
dialog.cpp. Specifically, it happens here:</div><div><br></div><div> <pre \
style="margin-top:0px;margin-bottom:0px;font-family:monospace">m_asyncDBManager(<span \
style="font-style:italic;font-family:monospace;color:rgb(120,86,45)">new</span><span \
style="font-family:monospace;color:rgb(77,79,82)"> </span><span \
style="font-family:monospace;color:rgb(153,0,0)">CatalogsDB</span>::<span \
style="font-family:monospace;color:rgb(153,0,0)">AsyncDBManager</span>(<span \
style="font-family:monospace;color:rgb(153,0,0)">CatalogsDB</span>::dso_db_path()))</pre><div><br></div><div>On \
line 65 when it constructs the new Asynch DB Manager. I did try changing the couple of lines of code in \
find dialog.cpp and find dialog.h so that it would use the old manager code from before this commit to \
verify if the new AsynchDBManger was really the culprit. And yes, it worked fine with the old code. \
So then I changed it back. Then I played around with the constructor for that class. Very strangely, I \
found that when I put my test QMessageBox message in just after line 772:</div><div><br></div><div> <pre \
style="margin-top:0px;margin-bottom:0px;font-family:monospace">m_thread<span \
style="font-family:monospace;color:rgb(120,86,45)">-></span>start();</pre><div><br></div></div><div>It \
didn't crash when it printed my debug QMessagebox but it did crash when I didn't have it there! That \
got me thinking that maybe for some reason, this object needed a little more time in its constructor for \
some reason, even though there are no more commands after that. So I just added a sleep command to see \
if that would serve the same purpose and it worked!</div><div><br></div><div> <pre \
style="margin-top:0px;margin-bottom:0px;font-family:monospace"><span \
style="font-family:monospace;color:rgb(255,128,128)">QThread</span>::msleep(<span \
style="font-family:monospace;color:rgb(138,96,44)">100</span>);</pre><div><br></div></div><div>So I would \
really like to know why this works. Here is a commit with a band aid for you guys to take a look \
at:</div><div><br></div><div><a href="https://invent.kde.org/education/kstars/-/merge_requests/706" \
target="_blank">https://invent.kde.org/education/kstars/-/merge_requests/706</a></div><div><br></div><div>Thanks,</div><div><br></div><div>Rob</div></div></div><div \
style="word-wrap:break-word;line-break:after-white-space"><div><div><br></div><div><br><blockquote \
type="cite"><div>On Aug 17, 2022, at 2:06 AM, Jasem Mutlaq <<a href="mailto:mutlaqja@ikarustech.com" \
target="_blank">mutlaqja@ikarustech.com</a>> wrote:</div><br><div><div dir="ltr">I received one report \
for Find Dialog crash as well on Raspberry Pi, so perhaps it's not unique to \
MacOS?<div><br></div><div>However, I couldn't reproduce on Raspberry PI, Widows, or any x86-64 \
machine.</div><div><br clear="all"><div><div dir="ltr" data-smartmail="gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div>--</div><div>Best Regards,<br>Jasem \
Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 17, 2022 at 8:52 AM Robert Lancaster \
<<a href="mailto:rlancaste@gmail.com" target="_blank">rlancaste@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div>Ok \
I did some more testing.<div><br></div><div>This commit is when the Find Dialog broke when running KStars \
on MacOS by double clicking the app:</div><div><br></div><div><a \
href="https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9" \
target="_blank">https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab7 \
63404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9</a></div><div><br></div><div>I think that is \
the one you were hoping was not the one. I still don't know why it broke it though. Every time I run \
it from terminal or qt creator there is no problem. It is just when running it by double clicking that \
is the problem.</div><div><br></div><div>Note that I did test playing with the environment variables in \
qt creator and that seemed to have no effect. And it also didn't seem to matter whether kstars was \
packaged up or not, so it doesn't seem to be a packaging issue.<br><div><br><blockquote \
type="cite"><div>On Aug 16, 2022, at 2:11 PM, Akarsh Simha <<a href="mailto:akarshsimha@gmail.com" \
target="_blank">akarshsimha@gmail.com</a>> wrote:</div><br><div><div dir="auto">If I am to blame for \
this, the parallelism introduced in the asynchronous find dialog is my suspect, rather than the comet \
regex (which was actually Hy and not me). The regex seems unlikely to cause the erratic behavior Robert \
is observing where it runs fine under a debugger.</div><div dir="auto"><br></div><div dir="auto">But if \
it works fine when running KStars from a command line, that probably exonerates me and Hy, and is likely \
an environment issue like Robert points out!</div><div dir="auto"><br></div><div \
dir="auto">Regards</div><div dir="auto">Akarsh</div><div dir="auto"><br></div><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 16, 2022 at 07:28 Robert Lancaster \
<<a href="mailto:rlancaste@gmail.com" target="_blank">rlancaste@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div>Hey \
guys,<div><br></div><div>I just got back from my two week trip to the Southwest. Yesterday I resolved \
the issue with building a dmg with my script, so now I can build DMGs that will work with older Macs and \
have all the features we want in the dmg. </div><div><br></div><div>Next we can look into this Find \
Dialog bug. I did some experiments today and I found that if I run kstars from the command line or in a \
debugger, the find dialog works fine, but when running the app by double clicking it crashes when you \
first access the find dialog. This seems to me to indicate an environment issue, like maybe an issue \
with environment variables or maybe a link to a library that isn't properly in the app. I will check \
further.</div><div><br></div><div>Thanks,</div><div><br></div><div>Rob</div></div><div><div><div><br><blockquote \
type="cite"><div>On Aug 13, 2022, at 6:09 AM, John Evans <<a \
href="mailto:john.e.evans.email@gmail.com" target="_blank">john.e.evans.email@gmail.com</a>> \
wrote:</div><br><div><div dir="ltr">I have the same problem with 3.6.0. Crashes everytime the find \
object dialog is invoked (button, keyboard, etc.)<div><br></div><div>Works great when I run it in debug \
in Qt though.</div><div><br></div><div>Workaround is to use the skymap and click on the object you want. \
In the scheduler enter some text in the object field (doesn't matter what) and hit the + to use sky \
coordinates from the map.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Sat, 13 Aug 2022 at 10:05, Akarsh Simha <<a href="mailto:akarshsimha@gmail.com" \
target="_blank">akarshsimha@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div><br></div><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 13, 2022 at 01:27 Peter Amerl <<a \
href="mailto:pvamerl@gmail.com" target="_blank">pvamerl@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">Hi \
All, <br> Has anyone else experienced an immediate crash when searching for objects on a Mac using the \
Apple-f key combination?<br> I can confirm that it has worked in the past without a crash. Neither \
Ctrl-f, nor selecting it from the menu appears to work for me at this time. <br> The Crash trace is \
appended in the zip if anyone wants to have a look.<br> </blockquote><div dir="auto"><br></div><div \
dir="auto">Hi Peter</div><div dir="auto"><br></div><div dir="auto">When you say it worked in the past, \
could you provide the exact version / git commit, and also your current version / git commit that has \
the bug? I made several changes to the Find Dialog in the most recent version, notably performing \
asynchronous database queries through another thread. It never crashed on my Linux system. Also curious \
if someone else can reproduce it on MacOS or if it is unique to your system.</div><div \
dir="auto"><br></div><div dir="auto">Regards</div><div dir="auto">Akarsh</div><div \
dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><br>
Cheers, <br>
Peter <br>
<br>
<br>
</blockquote></div></div>
</blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div></div>
</div></blockquote></div><br></div></div></blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic