[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: count-down issue
From: Jasem Mutlaq <mutlaqja () ikarustech ! com>
Date: 2022-02-16 15:50:52
Message-ID: CAE0bU5kihsNpRhjqhcpjTWJH7Fm-XmkuotXzp2Ycf79NQfjZsw () mail ! gmail ! com
[Download RAW message or body]
I think INDI behavior is correct. if nothing changed, don't send setXXX for
it. Therefore, we should fix it in Ekos with a timer.
--
Best Regards,
Jasem Mutlaq
On Wed, Feb 16, 2022 at 6:33 PM Wolfgang Reissenberger <
sterne-jaeger@openfuture.de> wrote:
> I think I could explain it. Running with the Telescope Simulator, the old
> and the new value at least on RA is *slightly* different in a range of
> 10^-8 and therefore at least for the simulator the coordinates update
> happens all the time.
>
> The question is: should we rework it in Ekos or in INDI? In INDI it's a
> matter of one single line, in EKOS it's quite an effort (and we need a new
> timer).
>
> Cheers
> Wolfgang
> —
> Wolfgang Reissenberger
>
> www.sterne-jaeger.de
> TSA-120 + FSQ-85 + epsilon-160 | Avalon Linear + M-zero | ASI 1600mm pro +
> 6200mm pro
>
> Am 16.02.2022 um 09:56 schrieb Jasem Mutlaq <mutlaqja@ikarustech.com>:
>
> Sorry, I was referring to INDI:
> https://github.com/indilib/indi/blob/f479114a60cddb7c4209e83824702de4efd58245/libs/indibase/inditelescope.cpp#L711
>
> --
> Best Regards,
> Jasem Mutlaq
>
>
>
> On Wed, Feb 16, 2022 at 11:28 AM Wolfgang Reissenberger <
> sterne-jaeger@openfuture.de> wrote:
>
> > I'm not sure whether I get it right. Inditelescope.cpp::248 has this
> > entry:
> >
> > emit newCoords(currentCoords, pierSide(), hourAngle());
> >
> >
> > This is unconditional, there is no check whether currentCoords equal the
> > previous one.
> >
> > Or are you talking about another place?
> >
> > Am 16.02.2022 um 09:22 schrieb Jasem Mutlaq <mutlaqja@ikarustech.com>:
> >
> > I don't think Ekos should depend on this behavior. INDI::Telescope
> > doesn't send updates when the previous values are identical.
> >
> > --
> > Best Regards,
> > Jasem Mutlaq
> >
> >
> > On Wed, Feb 16, 2022 at 11:09 AM Wolfgang Reissenberger
> > <sterne-jaeger@openfuture.de> wrote:
> >
> >
> > Ekos relies upon the INDI driver that it regularly sends the
> > EQUATORIAL_EOD_COORD coordinates - no matter whether they change or not.
> > The frequency is defined by the polling period defined in the INDI driver.
> >
> > If for whatever reason the INDI driver does not send them, the MF counter
> > won't be updated.
> >
> > We could indeed discuss whether it makes sense that Ekos relies upon a
> > regular update even if values do not change. But currently, at least for
> > the scope coordinates, it does.
> >
> > HTH
> > Wolfgang
> >
> > Am 16.02.2022 um 08:49 schrieb Jasem Mutlaq <mutlaqja@ikarustech.com>:
> >
> > Hello Hy,
> >
> > I don't believe this is an INDI driver issue. The driver is behaving
> > as it should. Ekos should do this. Also, I've been using this with
> > EQMod for many years and it works just fine, so what gives?
> >
> > --
> > Best Regards,
> > Jasem Mutlaq
> >
> >
> > On Wed, Feb 16, 2022 at 1:38 AM Hy Murveit <murveit@gmail.com> wrote:
> >
> >
> > I was noticing on the forum a thread you responded to where users were
> > complaining that the meridian-flip count-down wasn't working for their
> > Onstep mount.
> >
> > I had/fixed/hacked the same problem on my A-P driver.
> >
> > Here's what I believe is likely happening to them.
> >
> > The MF count-down is updated in a callback method that's watching the
> > RA/DEC from indi.
> > That is, in mount.cpp, updateTelescopeCoords calls checkMeridianFlip()
> > which does the updating of the counter. However, updateTelescopeCoords is
> > only called when the slot newCoords is hit. That signal is likely only sent
> > when the RA/DEC change, but when the scope is tracking, the RA and DEC
> > don't change!
> >
> > I saw that my driver wasn't updating its MF counter either (and
> > presumably, therefore wouldn't flip), but I know my old Eqmod mount did
> > work fine, so I assumed it was an issue in my A-P driver. FWIW, I added
> > this hack in my driver to get around the check for newness in newRaDec.
> >
> > Hy
> >
> >
> >
> >
>
[Attachment #3 (text/html)]
<div dir="ltr">I think INDI behavior is correct. if nothing changed, don't send \
setXXX for it. Therefore, we should fix it in Ekos with a timer.<div><br \
clear="all"><div><div dir="ltr" class="gmail_signature" \
data-smartmail="gmail_signature"><div dir="ltr"><div><div \
dir="ltr"><div>--</div><div>Best Regards,<br>Jasem \
Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 16, 2022 at 6:33 PM \
Wolfgang Reissenberger <<a \
href="mailto:sterne-jaeger@openfuture.de">sterne-jaeger@openfuture.de</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;">I think I could explain it. Running with the \
Telescope Simulator, the old and the new value at least on RA is <u>slightly</u> \
different in a range of 10^-8 and therefore at least for the simulator the \
coordinates update happens all the time.<div><br></div><div>The question is: should \
we rework it in Ekos or in INDI? In INDI it's a matter of one single line, in EKOS \
it's quite an effort (and we need a new \
timer).</div><div><br></div><div>Cheers</div><div>Wolfgang<br><div> <div dir="auto" \
style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div \
dir="auto" style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent: \
0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div \
dir="auto" style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent: \
0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div \
dir="auto" style="overflow-wrap: break-word;"><div \
style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-va \
riant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-inden \
t:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">—</div><div \
style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-va \
riant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-inden \
t:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">Wolfgang \
Reissenberger<br><br></div><div \
style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-va \
riant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-inden \
t:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><a \
href="http://www.sterne-jaeger.de" \
target="_blank">www.sterne-jaeger.de</a><br>TSA-120 + FSQ-85 + epsilon-160 | Avalon \
Linear + M-zero | ASI 1600mm pro + 6200mm pro</div></div></div></div></div> </div>
<div><br><blockquote type="cite"><div>Am 16.02.2022 um 09:56 schrieb Jasem Mutlaq \
<<a href="mailto:mutlaqja@ikarustech.com" \
target="_blank">mutlaqja@ikarustech.com</a>>:</div><br><div><div dir="ltr">Sorry, \
I was referring to INDI: <a \
href="https://github.com/indilib/indi/blob/f479114a60cddb7c4209e83824702de4efd58245/libs/indibase/inditelescope.cpp#L711" \
target="_blank">https://github.com/indilib/indi/blob/f479114a60cddb7c4209e83824702de4efd58245/libs/indibase/inditelescope.cpp#L711</a><div><br \
clear="all"><div><div dir="ltr"><div dir="ltr"><div><div \
dir="ltr"><div>--</div><div>Best Regards,<br>Jasem \
Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 16, 2022 at 11:28 \
AM Wolfgang Reissenberger <<a href="mailto:sterne-jaeger@openfuture.de" \
target="_blank">sterne-jaeger@openfuture.de</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div>I'm not sure whether I get it right. \
Inditelescope.cpp::248 has this entry:<div><br></div><div> <pre \
style="margin-top:0px;margin-bottom:0px"><span style="color:rgb(192,192,192)"> \
</span><span style="color:rgb(0,0,128)">emit</span><span \
style="color:rgb(192,192,192)"> </span><span \
style="color:rgb(0,103,124)">newCoords</span>(<span \
style="color:rgb(128,0,0)">currentCoords</span>,<span style="color:rgb(192,192,192)"> \
</span><span style="color:rgb(0,103,124)">pierSide</span>(),<span \
style="color:rgb(192,192,192)"> </span><span \
style="color:rgb(0,103,124)">hourAngle</span>());</pre> <pre \
style="margin-top:0px;margin-bottom:0px"><br></pre><div>This is unconditional, there \
is no check whether currentCoords equal the previous one.</div><div><br></div><div>Or \
are you talking about another place?</div><div><br><blockquote type="cite"><div>Am \
16.02.2022 um 09:22 schrieb Jasem Mutlaq <<a href="mailto:mutlaqja@ikarustech.com" \
target="_blank">mutlaqja@ikarustech.com</a>>:</div><br><div><div>I don't think \
Ekos should depend on this behavior. INDI::Telescope<br>doesn't send updates when \
the previous values are identical.<br><br>--<br>Best Regards,<br>Jasem \
Mutlaq<br><br><br>On Wed, Feb 16, 2022 at 11:09 AM Wolfgang Reissenberger<br><<a \
href="mailto:sterne-jaeger@openfuture.de" \
target="_blank">sterne-jaeger@openfuture.de</a>> wrote:<br><blockquote \
type="cite"><br>Ekos relies upon the INDI driver that it regularly sends the \
EQUATORIAL_EOD_COORD coordinates - no matter whether they change or not. The \
frequency is defined by the polling period defined in the INDI driver.<br><br>If for \
whatever reason the INDI driver does not send them, the MF counter won't be \
updated.<br><br>We could indeed discuss whether it makes sense that Ekos relies upon \
a regular update even if values do not change. But currently, at least for the scope \
coordinates, it does.<br><br>HTH<br>Wolfgang<br><br><blockquote type="cite">Am \
16.02.2022 um 08:49 schrieb Jasem Mutlaq <<a href="mailto:mutlaqja@ikarustech.com" \
target="_blank">mutlaqja@ikarustech.com</a>>:<br><br>Hello Hy,<br><br>I don't \
believe this is an INDI driver issue. The driver is behaving<br>as it should. Ekos \
should do this. Also, I've been using this with<br>EQMod for many years and it \
works just fine, so what gives?<br><br>--<br>Best Regards,<br>Jasem \
Mutlaq<br><br><br>On Wed, Feb 16, 2022 at 1:38 AM Hy Murveit <<a \
href="mailto:murveit@gmail.com" target="_blank">murveit@gmail.com</a>> \
wrote:<br><blockquote type="cite"><br>I was noticing on the forum a thread you \
responded to where users were complaining that the meridian-flip count-down \
wasn't working for their Onstep mount.<br><br>I had/fixed/hacked the same problem \
on my A-P driver.<br><br>Here's what I believe is likely happening to \
them.<br><br>The MF count-down is updated in a callback method that's watching \
the RA/DEC from indi.<br>That is, in mount.cpp, updateTelescopeCoords calls \
checkMeridianFlip() which does the updating of the counter. However, \
updateTelescopeCoords is only called when the slot newCoords is hit. That signal is \
likely only sent when the RA/DEC change, but when the scope is tracking, the RA and \
DEC don't change!<br><br>I saw that my driver wasn't updating its MF counter \
either (and presumably, therefore wouldn't flip), but I know my old Eqmod mount \
did work fine, so I assumed it was an issue in my A-P driver. FWIW, I added this \
hack in my driver to get around the check for newness in \
newRaDec.<br><br>Hy<br><br></blockquote></blockquote><br></blockquote></div></div></blockquote></div><br></div></div></blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic