[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: KStars v3.5.0 Release Date?
From: Robert Lancaster <rlancaste () gmail ! com>
Date: 2020-11-13 12:36:05
Message-ID: DB03B436-91EA-4D06-BE2A-40B7DC30A439 () gmail ! com
[Download RAW message or body]
" default profiles read-only in a resource file instead of pasted in the .local folder, so that we may \
adjust and optimise them throughout 3.5.x"
I am not 100% sure what you mean here since the defaults are actually generated in the code, they aren't \
in a file to start with right now. They also are in the KStars code so that they can be adjusted and \
optimized more easily by more people. As an alternative method, you could have a default file to start \
with, but that takes a little more effort in my opinion. But either way it could work
Sent from my iPhone
> On Nov 13, 2020, at 6:38 AM, Eric Dejouhanet <eric.dejouhanet@gmail.com> wrote:
>
> 
> I believe the ability to customise de profile is awesomely excellent. It's just that there should be an \
> easy way to "reset" profiles, although the community is used to "delete the KStars settings to start \
> from scratch", which is a simple but terrible option. This also paves the way for backward \
> incompatibilities that suddenly cripple an installation after an update. One easy way to allow profiles \
> to be reset is to prevent them from being overwritten, thus to not copy them to a writable location, \
> just as if they were application icons.
> About my default profile not detecting anything, Robert said it was because of the relatively small \
> size of the stars on the frame. My point is that I expect others to get the issue. There will be \
> support to be made in the forum.
> Regarding the "good set of data", I remember we also discussed about anonymous statistics and data \
> exchange between users. We should discuss your point in an issue in gitlab. eric.dejouhanet@gmail.com \
> - https://astronomy.dejouha.net
> De: murveit@gmail.com
> Envoyé: 13 novembre 2020 08:13
> À: eric.dejouhanet@gmail.com
> Répondre à : hy@murveit.com
> Cc: hy@murveit.com; rlancaste@gmail.com; mutlaqja@ikarustech.com; sterne-jaeger@openfuture.de; \
> kstars-devel@kde.org
> Objet: Re: KStars v3.5.0 Release Date?
>
> Eric,
>
> Profile Storage: Having those profiles in a more standard storage is fine by me. That's a discussion \
> with Rob--perhaps it's due to the separation between KStars and StellarSolver?
> Re the focus profile: sorry to hear that. Can you share an image or some insight as to what the problem \
> is? Ideally we could make one profile that worked for both of us, but if we need to, I suppose we could \
> make a few.
> Editorial comment: Really the focus issue you bring up is representative of the problem that we don't \
> have a good data set for testing things like that (I'd love 100 focus sessions from many different user \
> setups) so unfortunately, I design by "what seems to work for me" and then look for feedback from the \
> community. I'm not even sure what I'd ask for if I could get users to send me data, but I suppose I \
> could start with images from a few focus sessions.
> Hy
>
>
> > On Thu, Nov 12, 2020 at 11:01 PM Eric Dejouhanet <eric.dejouhanet@gmail.com> wrote:
> > Thanks for those fixes! On my side I adjusted the Focus UI toggling the capture button too soon, \
> > before detection is over. I'll publish the change in a few hours, and that should fix the relevant \
> > test too.
> > Hy, if end-users now see the real value of initKeep, to me this is acceptable as is, even if they \
> > need to edit the profiles. However, I would prefer to have the default profiles read-only in a \
> > resource file instead of pasted in the .local folder, so that we may adjust and optimise them \
> > throughout 3.5.x. After all, in my own personal, own and singular (but probably not isolated) case, \
> > the default profile detects nothing in the Focus module. But I know I'm late to that party, sorry \
> > about that. eric.dejouhanet@gmail.com - https://astronomy.dejouha.net
> >
> > De: murveit@gmail.com
> > Envoyé: 13 novembre 2020 07:01
> > À: rlancaste@gmail.com
> > Répondre à : hy@murveit.com
> > Cc: hy@murveit.com; eric.dejouhanet@gmail.com; mutlaqja@ikarustech.com; sterne-jaeger@openfuture.de; \
> > kstars-devel@kde.org
> > Objet: Re: KStars v3.5.0 Release Date?
> >
> > The program continues to run nicely for me in testing.
> > I tested Jasem's speedup to the polar align on my RPi and worked great.
> > The meridian flip checkbox issue is fixed, as far as I can tell.
> > For me, the star detection, guiding and focus are all good.
> > The bugs I found previously are all fixed, with a slight issue in the initialKeep thing.
> >
> > The initialKeep thing:
> > Rob has submitted (thanks Rob) an MR https://invent.kde.org/education/kstars/-/merge_requests/132 to \
> > fix the initialKeep issue--that edited profiles lose initialKeep, and it gets set to 1000000 causing \
> > possible very long computation times. I briefly tested the MR, and it (mostly--see below) looks fine \
> > to me. My only comment is to add some more flavor to the mouse-over doc, and ultimately to the \
> > handbook. The one issue I found, is that folks with old saved profiles, made before this fix -- so \
> > all existing saved profiles as of today -- will still have the problem until the user either deletes \
> > all their ~/.local/share/kstars/Saved*.ini files, or explicitly edits all their saved profiles and \
> > changes the initialKeep value from 1000000 to a reasonable number. Our choice is to either email out \
> > telling people to delete those files, and live with complaints from a few folks who don't delete them \
> > or change the names of those files (so all people who've edited profiles lose their profile work--but \
> > have a record of their lost data) I prefer the 2nd option--change the file names we look for--so \
> > effectively all files are deleted. Other than the initialKeep discussion above, I'm pretty happy with \
> > the code. Hy
> >
> > > On Thu, Nov 12, 2020 at 1:22 PM Robert Lancaster <rlancaste@gmail.com> wrote:
> > > Oops. "There was also a bug where Guide always used the index from focus, not it's own."
> > >
> > > Thanks for fixing that!
> > >
> > > > On Nov 12, 2020, at 3:48 PM, Hy Murveit <murveit@gmail.com> wrote:
> > > >
> > > > I found the bug related to the system always setting the users profile to profile #0 whenever the \
> > > > profile editor is used. This affected Guide, Focus & HFR, but not align (which has a different \
> > > > implementation than the rest, it seems). There was also a bug where Guide always used the index \
> > > > from focus, not it's own.
> > > > It was a simple change, as you can see in the MR \
> > > > https://invent.kde.org/education/kstars/-/merge_requests/131 and I tagged it as 3.5.0, but of \
> > > > course I'll leave it to Jasem to decide if it should be there.
> > > > Hy
> > > >
> > > > > On Thu, Nov 12, 2020 at 7:43 AM Robert Lancaster <rlancaste@gmail.com> wrote:
> > > > > Hi Eric,
> > > > >
> > > > > Yes it is mostly in KStars, the editor is in KStars, the default profiles are now in KStars \
> > > > > because we wanted everyone to have more control over the defaults so they can be tweaked in \
> > > > > nicely. But the reason that StellarSolver affected the saving of the profile here was because \
> > > > > the == operator for comparing the profiles is defined in parameters.cpp and the function for \
> > > > > conversion to and from an options map for saving or other uses is in parameters.cpp in \
> > > > > StellarSolver. I also have a convenience function for saving and loading profiles from a file \
> > > > > in StellarSolver (but that was not affected by this issue).
> > > > > > On Nov 12, 2020, at 9:10 AM, Eric Dejouhanet <eric.dejouhanet@gmail.com> wrote:
> > > > > >
> > > > > > Sorry if I was convinced the profile management was actually located in kstars and not in \
> > > > > > stellarsolver. eric.dejouhanet@gmail.com - https://astronomy.dejouha.net
> > > > > >
> > > > > > De: rlancaste@gmail.com
> > > > > > Envoyé: 12 novembre 2020 13:18
> > > > > > À: hy@murveit.com
> > > > > > Cc: eric.dejouhanet@gmail.com; mutlaqja@ikarustech.com; sterne-jaeger@openfuture.de; \
> > > > > > kstars-devel@kde.org
> > > > > > Objet: Re: KStars v3.5.0 Release Date?
> > > > > >
> > > > > > So the initial keep parameter not being saved was a bug in StellarSolver before, but I did \
> > > > > > fix it yesterday in StellarSolver before I sent those messages last night. You might have \
> > > > > > missed it but I did mention that I fixed it with the other stuff I said. So if you were \
> > > > > > using the older version yes it was not being saved, but now it should. It was fixed in this \
> > > > > > commit.
> > > > > > https://github.com/rlancaste/stellarsolver/commit/88135877f588c977e190977afca1c5132aacbbe2
> > > > > >
> > > > > > It was not being saved previously because we had added the initial keep parameter but then \
> > > > > > hadn't added it to the equals method nor to the options map method used in the file saving. \
> > > > > > Sorry I did not do this before, but I think what happened was that we were experimenting with \
> > > > > > the parameter, we were debating how it could be used, similarly to how we were in the emails \
> > > > > > yesterday, but we were still thinking about it and hadn't yet decided whether to leave it \
> > > > > > alone or change it, but then we moved on to other things and left it unfinished. But I did \
> > > > > > fix it yesterday after your email flagging this issue Eric and Hy's response which reminded \
> > > > > > me we hadn't finished it.
> > > > > > All that remains here is to add the parameter to the options profile editor in KStars now, \
> > > > > > which I was waiting to do until we discussed whether to keep it as is or change the names. I \
> > > > > > can add that to KStars next.
> > > > > > Sent from my iPhone
> > > > > >
> > > > > > > > On Nov 12, 2020, at 4:05 AM, Hy Murveit <murveit@gmail.com> wrote:
> > > > > > > >
> > > > > > > 
> > > > > > > Eric,
> > > > > > >
> > > > > > > Not sure which issue your were confirming. The possible initialKeep bug would not be \
> > > > > > > minor, if it's happening it could really make processing time long for hfr and focus, like \
> > > > > > > the 20s you're seeing. I'd vote to fix that if it's broken. The other one (spinbox) is an \
> > > > > > > annoyance, I'd lean towards fixing it now, but if you twisted my arm I guess I could agree \
> > > > > > > to wait.
> > > > > > > Hy
> > > > > > >
> > > > > > > > On Thu, Nov 12, 2020, 12:56 AM Eric Dejouhanet <eric.dejouhanet@gmail.com> wrote:
> > > > > > > > I confirm, but this is probably a minor that can be addressed in 3.5.1.
> > > > > > > > eric.dejouhanet@gmail.com - https://astronomy.dejouha.net
> > > > > > > >
> > > > > > > > De: murveit@gmail.com
> > > > > > > > Envoyé: 12 novembre 2020 09:37
> > > > > > > > À: eric.dejouhanet@gmail.com
> > > > > > > > Répondre à : hy@murveit.com
> > > > > > > > Cc: mutlaqja@ikarustech.com; hy@murveit.com; rlancaste@gmail.com; \
> > > > > > > > sterne-jaeger@openfuture.de; kstars-devel@kde.org
> > > > > > > > Objet: Re: KStars v3.5.0 Release Date?
> > > > > > > >
> > > > > > > > Eric: I see. So, can you check to see you don't have a file saved that's messing things \
> > > > > > > > up (e.g. delete your ~/.local/share/kstars/SavedFocusProfiles.ini file if it exists, and \
> > > > > > > > then make sure you're using the "1-Focus Default" profile). You could play with the \
> > > > > > > > initialKeep and keepNum values in the kstars/ekos/auxiliary/stellarsolverprofile.cpp file \
> > > > > > > > in the Focus method. (Also see the note to Rob below).
> > > > > > > > Rob: could there be a bug that if you have a saved .ini file, then the initialKeep \
> > > > > > > > parameter no longer gets set and uses a very high default? I wouldn't be surprised if \
> > > > > > > > that's what messing Eric up.
> > > > > > > > Hy
> > > > > > > >
> > > > > > > > > On Thu, Nov 12, 2020 at 12:24 AM Hy Murveit <murveit@gmail.com> wrote:
> > > > > > > > > Also, for the record, I do agree that Rob should either expose the initialKeep \
> > > > > > > > > parameter or make it a multiple of the Keep parameter. As it currently stands, it \
> > > > > > > > > effectively limits the maximum value of the keep parameter. H
> > > > > > > > >
> > > > > > > > > > On Thu, Nov 12, 2020 at 12:19 AM Hy Murveit <murveit@gmail.com> wrote:
> > > > > > > > > > Jasem: I can go either way I suppose, but in my experience, it's running reasonably \
> > > > > > > > > > quickly. I won't object too strongly if you want to fix it.
> > > > > > > > > > Eric: When I processed your images on my RPi4, they processed reasonably quickly:
> > > > > > > > > >
> > > > > > > > > > Looking at the 1x1 image:
> > > > > > > > > > Computing the HFR took 1-2s, but that's using my "quick HFR" which only looks at \
> > > > > > > > > > stars in the middle 25% of the image. Turning off the quick HFR option slowed it down \
> > > > > > > > > > to 4-5 seconds (again possibly alongside guiding). Are you using something slower \
> > > > > > > > > > than a RPi4? Could there be something else slowing down the computations?
> > > > > > > > > > Looking at the 2x2 image:
> > > > > > > > > > Seemed to take 1-2s without quickhfr, and 1s or less with quickhfr.
> > > > > > > > > > FWIW, I run my focus with 2x2 binning of a ZWO ASI 1600.
> > > > > > > > > >
> > > > > > > > > > We should figure out what the issue is.
> > > > > > > > > > Hy
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > > On Wed, Nov 11, 2020 at 11:50 PM Eric Dejouhanet <eric.dejouhanet@gmail.com> wrote:
> > > > > > > > > > > Which is my case right now. But in the particular subject of 3.5, I agree. I would \
> > > > > > > > > > > like to know if the profiles are editable by the end-user when they are saved \
> > > > > > > > > > > locally, I mean, are all parameters from the file loaded back properly?
> > > > > > > > > > > You know what I also mean here. Are there any tests validating that part?
> > > > > > > > > > >
> > > > > > > > > > > eric.dejouhanet@gmail.com - https://astronomy.dejouha.net
> > > > > > > > > > >
> > > > > > > > > > > De: mutlaqja@ikarustech.com
> > > > > > > > > > > Envoyé: 12 novembre 2020 08:46
> > > > > > > > > > > À: hy@murveit.com
> > > > > > > > > > > Cc: rlancaste@gmail.com; eric.dejouhanet@gmail.com; sterne-jaeger@openfuture.de; \
> > > > > > > > > > > kstars-devel@kde.org
> > > > > > > > > > > Objet: Re: KStars v3.5.0 Release Date?
> > > > > > > > > > >
> > > > > > > > > > > That's fine with me. As long as it does end up generating too many stars that ends \
> > > > > > > > > > > up clogging HFR calculations unnecessarily.
> > > > > > > > > > > --
> > > > > > > > > > > Best Regards,
> > > > > > > > > > > Jasem Mutlaq
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > > On Thu, Nov 12, 2020 at 10:35 AM Hy Murveit <murveit@gmail.com> wrote:
> > > > > > > > > > > > Jasem,
> > > > > > > > > > > >
> > > > > > > > > > > > This close to the release, I'm inclined to be conservative here and let it be.
> > > > > > > > > > > > It's just something I came up with, not some reference algorithm, and it seems to \
> > > > > > > > > > > > be working as it was implemented. I suggest that we can play with this in 3.5.1 \
> > > > > > > > > > > > if you want, but not mess with this now.
> > > > > > > > > > > > Hy
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > > On Wed, Nov 11, 2020 at 11:11 PM Jasem Mutlaq <mutlaqja@ikarustech.com> wrote:
> > > > > > > > > > > > > Hello Robert,
> > > > > > > > > > > > >
> > > > > > > > > > > > > Good catch on the partition & keep stars. I think we ought to resolve this not \
> > > > > > > > > > > > > by simply dividing by the number of chunks as this might skew the results. In \
> > > > > > > > > > > > > some images, some regions are more star-rich than others. Maybe we should do a \
> > > > > > > > > > > > > POST star detection but PRE star filter step where the # of stars are then \
> > > > > > > > > > > > > trimmed to the required initial keep?
> > > > > > > > > > > > > --
> > > > > > > > > > > > > Best Regards,
> > > > > > > > > > > > > Jasem Mutlaq
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > > On Thu, Nov 12, 2020 at 9:41 AM Robert Lancaster <rlancaste@gmail.com> wrote:
> > > > > > > > > > > > > > Oh the more significant question that I asked though, I don't think we \
> > > > > > > > > > > > > > addressed it yet. Right now initial keep doesn't work the way you meant it \
> > > > > > > > > > > > > > to due to the partitions. Does that need to be changed?
> > > > > > > > > > > > > > Sent from my iPhone
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On Nov 12, 2020, at 1:37 AM, Robert Lancaster <rlancaste@gmail.com> wrote:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Yep they are the same kind of thing when it comes to stars certainly. \
> > > > > > > > > > > > > > > Your argument that HFR should correlate to magnitude is probably very true \
> > > > > > > > > > > > > > > for stars, but not for nebulae or galaxies. They can be large but dim. It \
> > > > > > > > > > > > > > > also might not be true for some stars with dust around them
> > > > > > > > > > > > > > > Sent from my iPhone
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > On Nov 12, 2020, at 1:24 AM, Hy Murveit <murveit@gmail.com> wrote:
> > > > > > > > > > > > > > > >
> > > > >
> > >
[Attachment #3 (text/html)]
<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body \
dir="auto">" <span style="-webkit-text-size-adjust: auto; caret-color: rgb(0, 0, 0); color: rgb(0, \
0, 0); font-size: medium; background-color: rgb(255, 255, 255);">default profiles read-only in a resource \
file instead of pasted in the .local folder, so that we may adjust and optimise them throughout \
3.5.x"</span><br><div><br></div><div>I am not 100% sure what you mean here since the defaults are \
actually generated in the code, they aren't in a file to start with right now.</div><div>They also are in \
the KStars code so that they can be adjusted and optimized more easily by more people.</div><div>As an \
alternative method, you could have a default file to start with, but that takes a little more effort in \
my opinion. But either way it could work </div><div><br></div><div><div dir="ltr">Sent from my \
iPhone</div><div dir="ltr"><br><blockquote type="cite">On Nov 13, 2020, at 6:38 AM, Eric Dejouhanet \
<eric.dejouhanet@gmail.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div \
dir="ltr"><style id="outgoing-font-settings">#response_container_BBPPID{font-family: \
initial;font-size: initial;color: initial;}</style><div id="response_container_BBPPID" \
style="outline:none" dir="auto" contenteditable="false"> <div id="BB10_response_div_BBPPID" dir="auto" \
style="width:100%">I believe the ability to customise de profile is awesomely excellent. It's just that \
there should be an easy way to "reset" profiles, although the community is used to "delete the KStars \
settings to start from scratch", which is a simple but terrible option. This also paves the way for \
backward incompatibilities that suddenly cripple an installation after an update. One easy way to allow \
profiles to be reset is to prevent them from being overwritten, thus to not copy them to a writable \
location, just as if they were application icons. </div><div id="BB10_response_div_BBPPID" \
dir="auto" style="width:100%"><br></div><div id="BB10_response_div_BBPPID" dir="auto" \
style="width:100%">About my default profile not detecting anything, Robert said it was because of the \
relatively small size of the stars on the frame. My point is that I expect others to get the issue. There \
will be support to be made in the forum. </div> \
<div id="response_div_spacer_BBPPID" dir="auto" style="width:100%"> <br></div><div \
id="response_div_spacer_BBPPID" dir="auto" style="width:100%">Regarding the "good set of data", I \
remember we also discussed about anonymous statistics and data exchange between users. We should discuss \
your point in an issue in gitlab. </div> <div id="blackberry_signature_BBPPID" dir="auto"> <div \
id="_signaturePlaceholder_BBPPID" dir="auto"><p dir="ltr">eric.dejouhanet@gmail.com - \
https://astronomy.dejouha.net</p></div> </div></div><div id="_original_msg_header_BBPPID" dir="auto"> \
<table id="_pHCWrapper_BBPPID" width="100%" style="border-spacing: 0px; display: table; outline: none;" \
contenteditable="false"><tbody><tr><td colspan="2"> <div \
style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb( 181 , 196 , 223 \
);padding:3pt 0in 0in;font-family:'tahoma' , 'bb alpha sans' , 'slate pro';font-size:10pt"> <div \
id="from"><b>De:</b> murveit@gmail.com</div><div id="sent"><b>Envoyé:</b> 13 novembre 2020 \
08:13</div><div id="to"><b>À:</b> eric.dejouhanet@gmail.com</div><div id="reply_to"><b>Répondre à :</b> \
hy@murveit.com</div><div id="cc"><b>Cc:</b> hy@murveit.com; rlancaste@gmail.com; mutlaqja@ikarustech.com; \
sterne-jaeger@openfuture.de; kstars-devel@kde.org</div><div id="subject"><b>Objet:</b> Re: KStars v3.5.0 \
Release Date?</div></div></td></tr></tbody></table> <br> </div><div dir="auto" style="outline:none" \
contenteditable="false"><div dir="ltr">Eric, <br><div><br></div><div><b>Profile Storage</b>: Having \
those profiles in a more standard storage is fine by me. That's a discussion with Rob--perhaps it's \
due to the separation between KStars and StellarSolver?</div><div><br></div><div><b>Re the \
focus profile</b>: sorry to hear that. Can you share an image or some insight as to what the problem is? \
Ideally we could make one profile that worked for both of us, but if we need to, I suppose we could make \
a few.</div><div><br></div><div><b>Editorial comment</b>: Really the focus issue you bring up is \
representative of the problem that we don't have a good data set for testing things like that (I'd love \
100 focus sessions from many different user setups) so unfortunately, I design by "what seems to work for \
me" and then look for feedback from the community. I'm not even sure what I'd ask for if I could get \
users to send me data, but I suppose I could start with images from a few focus \
sessions.</div><div><br></div><div>Hy</div><div><br></div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Thu, Nov 12, 2020 at 11:01 PM Eric Dejouhanet <<a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb( 204 , 204 , 204 \
);padding-left:1ex"><div style="background-color:rgb( 255 , 255 , 255 )"><div \
id="gmail-m_3441471075771953158response_container_BBPPID" style="outline:none" dir="auto"> <div \
id="gmail-m_3441471075771953158BB10_response_div_BBPPID" dir="auto" style="width:100%">Thanks for those \
fixes! On my side I adjusted the Focus UI toggling the capture button too soon, before detection is over. \
I'll publish the change in a few hours, and that should fix the relevant test too. </div><div \
id="gmail-m_3441471075771953158BB10_response_div_BBPPID" dir="auto" style="width:100%"><br></div><div \
id="gmail-m_3441471075771953158BB10_response_div_BBPPID" dir="auto" style="width:100%">Hy, if end-users \
now see the real value of initKeep, to me this is acceptable as is, even if they need to edit the \
profiles. However, I would prefer to have the default profiles read-only in a resource file instead of \
pasted in the .local folder, so that we may adjust and optimise them throughout 3.5.x. After all, in my \
own personal, own and singular (but probably not isolated) case, the default profile detects nothing in \
the Focus module. But I know I'm late to that party, sorry about that. </div> <div \
id="gmail-m_3441471075771953158blackberry_signature_BBPPID" dir="auto"> <div \
id="gmail-m_3441471075771953158_signaturePlaceholder_BBPPID" dir="auto"><p dir="ltr"><a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a> - <a \
href="https://astronomy.dejouha.net">https://astronomy.dejouha.net</a></p></div> </div></div><div \
id="gmail-m_3441471075771953158_original_msg_header_BBPPID" dir="auto"> \
<table width="100%" style="border-spacing:0px;display:table;outline:none"><tbody><tr><td colspan="2"> \
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb( 181 , 196 , \
223 );padding:3pt 0in 0in;font-family:'tahoma' , 'bb alpha sans' , 'slate pro';font-size:10pt"> <div \
id="gmail-m_3441471075771953158from"><b>De:</b> <a \
href="mailto:murveit@gmail.com">murveit@gmail.com</a></div><div \
id="gmail-m_3441471075771953158sent"><b>Envoyé:</b> 13 novembre 2020 07:01</div><div \
id="gmail-m_3441471075771953158to"><b>À:</b> <a \
href="mailto:rlancaste@gmail.com">rlancaste@gmail.com</a></div><div \
id="gmail-m_3441471075771953158reply_to"><b>Répondre à :</b> <a \
href="mailto:hy@murveit.com">hy@murveit.com</a></div><div id="gmail-m_3441471075771953158cc"><b>Cc:</b> \
<a href="mailto:hy@murveit.com">hy@murveit.com</a>; <a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a>; <a \
href="mailto:mutlaqja@ikarustech.com">mutlaqja@ikarustech.com</a>; <a \
href="mailto:sterne-jaeger@openfuture.de">sterne-jaeger@openfuture.de</a>; <a \
href="mailto:kstars-devel@kde.org">kstars-devel@kde.org</a></div><div \
id="gmail-m_3441471075771953158subject"><b>Objet:</b> Re: KStars v3.5.0 Release \
Date?</div></div></td></tr></tbody></table> <br> </div><div dir="auto" style="outline:none"><div \
dir="ltr">The program continues to run nicely for me in testing.<div>I tested Jasem's speedup to the \
polar align on my RPi and worked great. </div><div>The meridian flip checkbox issue is fixed, as \
far as I can tell.</div><div>For me, the star detection, guiding and focus are all \
good.</div><div>The bugs I found previously are all fixed, with a slight issue in the initialKeep \
thing.</div><div><br></div><div>The initialKeep thing:</div><div><ul><li>Rob has submitted (thanks Rob) \
an MR <a href="https://invent.kde.org/education/kstars/-/merge_requests/132">https://invent.kde.org/education/kstars/-/merge_requests/132</a> \
to fix the initialKeep issue--that edited profiles lose initialKeep, and it gets set to 1000000 causing \
possible very long computation times.</li><li>I briefly tested the MR, and it (mostly--see below) looks \
fine to me. My only comment is to add some more flavor to the mouse-over doc, and ultimately to the \
handbook.</li><li>The one issue I found, is that folks with old saved profiles, made before this fix -- \
so<span style="background-color:rgb( 255 , 255 , 0 )"> all existing saved profiles as of today -- will \
still have the problem </span>until the user either deletes all their ~/.local/share/kstars/Saved*.ini \
files, or explicitly edits all their saved profiles and changes the initialKeep value from 1000000 to a \
reasonable number. Our choice is to</li><li><ul><li>either email out telling people to delete those \
files, and live with complaints from a few folks who don't delete them</li><li>or change the names of \
those files (so all people who've edited profiles lose their profile work--but have a record of their \
lost data)</li><li>I prefer the 2nd option--change the file names we look for--so effectively all files \
are deleted.</li></ul></li></ul></div><div>Other than the initialKeep discussion above, I'm pretty happy \
with the code.</div><div>Hy</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Thu, Nov 12, 2020 at 1:22 PM Robert Lancaster <<a \
href="mailto:rlancaste@gmail.com">rlancaste@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb( 204 , 204 , 204 \
);padding-left:1ex"><div>Oops. "<span style="color:rgb( 0 , 0 , 0 )">There was also a bug where Guide \
always used the index from focus, not it's own.</span><font color="#000000">"</font><div><font \
color="#000000"><br></font></div><div><font color="#000000">Thanks for fixing \
that!<br></font><div><br><blockquote type="cite"><div>On Nov 12, 2020, at 3:48 PM, Hy Murveit <<a \
href="mailto:murveit@gmail.com">murveit@gmail.com</a>> wrote:</div><br><div><div dir="ltr">I found the \
bug related to the system always setting the users profile to profile #0 whenever the profile editor is \
used.<div>This affected Guide, Focus & HFR, but not align (which has a different implementation than \
the rest, it seems).</div><div>There was also a bug where Guide always used the index from focus, \
not it's own.</div><div><br></div><div>It was a simple change, as you can see in the MR <a \
href="https://invent.kde.org/education/kstars/-/merge_requests/131">https://invent.kde.org/education/kstars/-/merge_requests/131</a></div><div>and \
I tagged it as 3.5.0, but of course I'll leave it to Jasem to decide if it should be \
there.</div><div><br></div><div>Hy</div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, Nov 12, 2020 at 7:43 AM Robert Lancaster <<a \
href="mailto:rlancaste@gmail.com">rlancaste@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb( 204 , 204 , 204 \
);padding-left:1ex"><div>Hi Eric,<div><br></div><div>Yes it is mostly in KStars, the editor is in KStars, \
the default profiles are now in KStars because we wanted everyone to have more control over the defaults \
so they can be tweaked in nicely. But the reason that StellarSolver affected the saving of the \
profile here was because the == operator for comparing the profiles is defined in <a \
href="http://parameters.cpp">parameters.cpp</a> and the function for conversion to and from an options \
map for saving or other uses is in <a href="http://parameters.cpp">parameters.cpp</a> in \
StellarSolver. I also have a convenience function for saving and loading profiles from a file in \
StellarSolver (but that was not affected by this issue).<br><div><br><blockquote type="cite"><div>On Nov \
12, 2020, at 9:10 AM, Eric Dejouhanet <<a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a>> wrote:</div><br><div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033response_container_BBPPID" \
dir="auto" style="font-family:'helvetica';font-style:normal;font-weight:normal;letter-spacing:normal;text- \
indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb( 255 , 255 , 255 \
);text-decoration:none;outline:none"><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033BB10_response_div_BBPPID" \
dir="auto" style="width:1013px">Sorry if I was convinced the profile management was actually located in \
kstars and not in stellarsolver. </div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033blackberry_signature_BBPPID" \
dir="auto"><div id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033_signaturePlaceholder_BBPPID" \
dir="auto"><p dir="ltr"><a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a> - <a \
href="https://astronomy.dejouha.net/">https://astronomy.dejouha.net</a></p></div></div></div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033_original_msg_header_BBPPID" \
dir="auto" style="font-family:'helvetica';font-size:12px;font-style:normal;font-weight:normal;letter-spaci \
ng:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb( \
255 , 255 , 255 );text-decoration:none"><table width="100%" \
style="border-spacing:0px;display:table;outline:none"><tbody><tr><td colspan="2"><div \
style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb( 181 , 196 , 223 \
);padding:3pt 0in 0in;font-family:'tahoma' , 'bb alpha sans' , 'slate pro';font-size:10pt"><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033from"><b>De:</b> <a \
href="mailto:rlancaste@gmail.com">rlancaste@gmail.com</a></div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033sent"><b>Envoyé:</b> 12 \
novembre 2020 13:18</div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033to"><b>À:</b> <a \
href="mailto:hy@murveit.com">hy@murveit.com</a></div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033cc"><b>Cc:</b> <a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a>; <a \
href="mailto:mutlaqja@ikarustech.com">mutlaqja@ikarustech.com</a>; <a \
href="mailto:sterne-jaeger@openfuture.de">sterne-jaeger@openfuture.de</a>; <a \
href="mailto:kstars-devel@kde.org">kstars-devel@kde.org</a></div><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033subject"><b>Objet:</b> Re: \
KStars v3.5.0 Release Date?</div></div></td></tr></tbody></table><br></div><div dir="auto" \
style="font-family:'helvetica';font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;t \
ext-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb( 255 , 255 , \
255 );text-decoration:none;outline:none"><div dir="auto"></div>So the initial keep parameter not being \
saved was a bug in StellarSolver before, but I did fix it yesterday in StellarSolver before I sent those \
messages last night. You might have missed it but I did mention that I fixed it with the other \
stuff I said. So if you were using the older version yes it was not being saved, but now it \
should. It was fixed in this commit.<div><br></div><div><a \
href="https://github.com/rlancaste/stellarsolver/commit/88135877f588c977e190977afca1c5132aacbbe2">https:// \
github.com/rlancaste/stellarsolver/commit/88135877f588c977e190977afca1c5132aacbbe2</a></div><div><br></div><div>It \
was not being saved previously because we had added the initial keep parameter but then hadn't added it \
to the equals method nor to the options map method used in the file saving. Sorry I did not do this \
before, but I think what happened was that we were experimenting with the parameter, we were debating how \
it could be used, similarly to how we were in the emails yesterday, but we were still thinking about it \
and hadn't yet decided whether to leave it alone or change it, but then we moved on to other things and \
left it unfinished. But I did fix it yesterday after your email flagging this issue Eric and Hy's \
response which reminded me we hadn't finished it.</div><div><br></div><div>All that remains here is to \
add the parameter to the options profile editor in KStars now, which I was waiting to do until we \
discussed whether to keep it as is or change the names. I can add that to KStars next.<br><br><div \
dir="ltr">Sent from my iPhone</div><div dir="ltr"><br><blockquote type="cite">On Nov 12, 2020, at 4:05 \
AM, Hy Murveit <<a href="mailto:murveit@gmail.com">murveit@gmail.com</a>> \
wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div \
dir="auto">Eric, <div dir="auto"><br></div><div dir="auto">Not sure which issue your were \
confirming. The possible initialKeep bug would not be minor, if it's happening it could \
really make processing time long for hfr and focus, like the 20s you're seeing. I'd vote to fix that if \
it's broken. The other one (spinbox) is an annoyance, I'd lean towards fixing it now, but if you twisted \
my arm I guess I could agree to wait.<div dir="auto"><br></div><div \
dir="auto">Hy</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Nov \
12, 2020, 12:56 AM Eric Dejouhanet <<a \
href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb( 204 , 204 , 204 \
);padding-left:1ex"><div style="background-color:rgb( 255 , 255 , 255 )"><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033m_3652298360928128828response_container_BBPPID" \
dir="auto" style="outline:none"><div \
id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033m_3652298360928128828BB10_response_div_BBPPID" \
dir="auto" style="width:990.719px">I confirm, but this is probably a minor that can be addressed in \
3.5.1.</div><div id="gmail-m_3441471075771953158gmail-m_-1339768599457799681gmail-m_3062718894205722033m_3652298360928128828blackberry_signature_BBPPID" \
</div></blockquote></div><br></div></div></blockquote></div>
</div></div></blockquote></div>
</div></div></blockquote></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic