[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: Review Request 129688: kstars: Update Czech Republic to Czechia
From: Albert Astals Cid <aacid () kde ! org>
Date: 2017-01-17 22:25:06
Message-ID: 20170117222506.31352.23047 () mimi ! kde ! org
[Download RAW message or body]
--===============5798802132698397197==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129688/#review102084
-----------------------------------------------------------
you'll have to be more clear here since a diff over a binary file doesn't quite work.
- Albert Astals Cid
On Dec. 20, 2016, 9:42 p.m., Jiri Bohac wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129688/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 9:42 p.m.)
>
>
> Review request for KStars and Albert Astals Cid.
>
>
> Repository: kstars
>
>
> Description
> -------
>
> This year the country has oficially adopted the short name Czechia.
> The short name has been entered to the UNTERM and UNGEGN databases in July 2016.
> Czechia is used in iso_3166 since September 2016.
>
> This is a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
> country names are hardcoded in many places and they need to be fixed separately.
>
>
> Diffs
> -----
>
> kstars/data/citydb.sqlite a475c63dfa9fbdbbf66b582f6a3653a26b49f170
>
> Diff: https://git.reviewboard.kde.org/r/129688/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiri Bohac
>
>
--===============5798802132698397197==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129688/">https://git.reviewboard.kde.org/r/129688/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">you'll have to be more clear here since a diff over a binary file doesn't \
quite work.</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On December 20th, 2016, 9:42 p.m. UTC, Jiri Bohac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KStars and Albert Astals Cid.</div>
<div>By Jiri Bohac.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2016, 9:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This year the country has oficially adopted the short name Czechia. The \
short name has been entered to the UNTERM and UNGEGN databases in July 2016. Czechia \
is used in iso_3166 since September 2016.
This is a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
country names are hardcoded in many places and they need to be fixed \
separately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/data/citydb.sqlite <span style="color: \
grey">(a475c63dfa9fbdbbf66b582f6a3653a26b49f170)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129688/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5798802132698397197==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic