'Re: [Kstars-devel] Review Request 116965: Added exponential zoom in/out feature in Solar System View'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 116965: Added exponential zoom in/out feature in Solar System View
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2014-04-12 22:14:36
Message-ID: 20140412221436.22681.19625 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116965/
-----------------------------------------------------------

(Updated April 12, 2014, 10:14 p.m.)

Status
------

This change has been marked as submitted.

Review request for KStars and Rafal Kulaga.

Repository: kstars

Description
-------

Currently zoom in/out factor is set constant which is very small so zoom in/out works \
very slowly, i.e. user have to keep rolling mouse wheel for long to get zoom enough \
to observe single planet. 

This features allows user to do quick zoom in/out by pressing ctrl + wheel/+-keys. 

Diffs
-----

  kstars/tools/pvplotwidget.h ef90ace 
  kstars/tools/pvplotwidget.cpp b8a8b30 

Diff: https://git.reviewboard.kde.org/r/116965/diff/

Testing
-------

Testing has done for following use cases:
1) Zoom in/out by pressing +/- continuously till it can not zoom in/out furthermore 
2) Zoom in/out by rolling rolling wheel up/down continuously till it can not zoom \
in/out furthermore  3) Zoom in/out by pressing Ctrl + +/- continuously till it can \
not zoom in/out furthermore  4) Zoom in/out by rolling Ctrl + rolling wheel up/down \
continuously till it can not zoom in/out furthermore  5) Zoom in/out by pressing +/- \
step by step till it can not zoom in/out furthermore  6) Zoom in/out by rolling \
rolling wheel up/down step by step till it can not zoom in/out furthermore  7) Zoom \
in/out by pressing Ctrl + +/- step by step till it can not zoom in/out furthermore  \
8) Zoom in/out by rolling Ctrl + rolling wheel up/down step by step till it can not \
zoom in/out furthermore

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116965/">https://git.reviewboard.kde.org/r/116965/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated April 12, 2014, 10:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently zoom in/out factor is set constant which is very small so zoom \
in/out works very slowly, i.e. user have to keep rolling mouse wheel for long to get \
zoom enough to observe single planet. 

This features allows user to do quick zoom in/out by pressing ctrl + wheel/+-keys. \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing has done for following use cases: 1) Zoom in/out by pressing +/- \
continuously till it can not zoom in/out furthermore  2) Zoom in/out by rolling \
rolling wheel up/down continuously till it can not zoom in/out furthermore  3) Zoom \
in/out by pressing Ctrl + +/- continuously till it can not zoom in/out furthermore  \
4) Zoom in/out by rolling Ctrl + rolling wheel up/down continuously till it can not \
zoom in/out furthermore  5) Zoom in/out by pressing +/- step by step till it can not \
zoom in/out furthermore  6) Zoom in/out by rolling rolling wheel up/down step by step \
till it can not zoom in/out furthermore  7) Zoom in/out by pressing Ctrl + +/- step \
by step till it can not zoom in/out furthermore  8) Zoom in/out by rolling Ctrl + \
rolling wheel up/down step by step till it can not zoom in/out furthermore </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/tools/pvplotwidget.h <span style="color: grey">(ef90ace)</span></li>

 <li>kstars/tools/pvplotwidget.cpp <span style="color: grey">(b8a8b30)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116965/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 