'Re: [Kstars-devel] Review Request 115975: Fixed minor bug in Solar System Viewer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 115975: Fixed minor bug in Solar System Viewer
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2014-02-25 19:02:32
Message-ID: 20140225190232.11047.69962 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115975/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 7:02 p.m.)

Status
------

This change has been marked as submitted.

Review request for KStars and Rafal Kulaga.

Repository: kstars

Description
-------

There happens change in icon of pause/play button in Solar System Viewer according to \
state of timer. So If timer is on and viewer is closed then on opening solar system \
viewer again, the icon in button is pause icon even though system is in pause mode.

So this bug is fixed by setting icon on button to play icon before closing window \
when we are actually pausing system.

Diffs
-----

  kstars/tools/planetviewer.cpp fd7e73a 

Diff: https://git.reviewboard.kde.org/r/115975/diff/

Testing
-------

Tested

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115975/">https://git.reviewboard.kde.org/r/115975/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Feb. 25, 2014, 7:02 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There happens change in icon of pause/play button in Solar System Viewer \
according to state of timer. So If timer is on and viewer is closed then on opening \
solar system viewer again, the icon in button is pause icon even though system is in \
pause mode.

So this bug is fixed by setting icon on button to play icon before closing window \
when we are actually pausing system.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/tools/planetviewer.cpp <span style="color: grey">(fd7e73a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115975/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 