[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: [Kstars-devel] Review Request 112667: Add solar/lunar eclipse button to conjunction tool
From: "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date: 2014-02-23 18:06:29
Message-ID: 20140223180629.22874.24616 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 23, 2014, 5:01 p.m., Albert Astals Cid wrote:
> > I guess this needs fixing because of the discussion in the irc channel:
> >
> > [22:49:32] <kstar> tsdgeos: Oh, I meant to tell you that I had some complaints \
> > with that. [22:49:43] <kstar> tsdgeos: Including the fact that the lunar eclipse \
> > calculations are in principle incorrect. [22:50:07] <kstar> tsdgeos: I'm sorry I \
> > cannot be active on KStars anymore. hdevalence seems to have more time than me \
> > these days. [22:50:37] <kstar> vijay13: When you're computing a lunar eclipse, \
> > the diameter for the conjunction has to be the size of the umbra of the earth. \
> > [22:50:44] <kstar> i.e. the angle subtended by the earth at the moon. [22:51:23] \
> > <kstar> So you can calculate oppositions, but the tolerance must be (if I \
> > understand correctly), the diameter of the sun at the moon + the diameter of the \
> > earth at the moon or something like that. [22:52:41] <vijay13> kstar: seems \
> > logical what you saying , I am ashamed of maself ;-) i just used shortway that \
> > time
This patch is not more valid, since there is need to implement complete new logic to \
calculate lunar eclipse so I am closing this review request.
- Vijay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/#review50598
-----------------------------------------------------------
On Feb. 23, 2014, 6:06 p.m., Vijay Dhameliya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112667/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2014, 6:06 p.m.)
>
>
> Review request for KDE Edu, KStars and Rafal Kulaga.
>
>
> Repository: kstars
>
>
> Description
> -------
>
> Add solar/lunar eclipse button to conjunctions tool for better usability
>
>
> Diffs
> -----
>
> kstars/tools/conjunctions.h 2e37651
> kstars/tools/conjunctions.cpp 529f91d
> kstars/tools/conjunctions.ui d4c5138
>
> Diff: https://git.reviewboard.kde.org/r/112667/diff/
>
>
> Testing
> -------
>
> Tested , it predicts correct dates of eclipse but some eclipse may not get \
> displayed
>
> Thanks,
>
> Vijay Dhameliya
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112667/">https://git.reviewboard.kde.org/r/112667/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 23rd, 2014, 5:01 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I guess this needs fixing because of the discussion in the irc channel:
[22:49:32] <kstar> tsdgeos: Oh, I meant to tell you that I had some complaints \
with that. [22:49:43] <kstar> tsdgeos: Including the fact that the lunar \
eclipse calculations are in principle incorrect. [22:50:07] <kstar> tsdgeos: \
I'm sorry I cannot be active on KStars anymore. hdevalence seems to have more \
time than me these days. [22:50:37] <kstar> vijay13: When you're computing \
a lunar eclipse, the diameter for the conjunction has to be the size of the umbra of \
the earth. [22:50:44] <kstar> i.e. the angle subtended by the earth at the \
moon. [22:51:23] <kstar> So you can calculate oppositions, but the tolerance \
must be (if I understand correctly), the diameter of the sun at the moon + the \
diameter of the earth at the moon or something like that. [22:52:41] <vijay13> \
kstar: seems logical what you saying , I am ashamed of maself ;-) i just used \
shortway that time </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is not more \
valid, since there is need to implement complete new logic to calculate lunar eclipse \
so I am closing this review request. </pre> <br />
<p>- Vijay</p>
<br />
<p>On February 23rd, 2014, 6:06 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add solar/lunar eclipse button to conjunctions tool for better usability \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested , it predicts correct dates of eclipse but some eclipse may not \
get displayed</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/conjunctions.h <span style="color: grey">(2e37651)</span></li>
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(529f91d)</span></li>
<li>kstars/tools/conjunctions.ui <span style="color: grey">(d4c5138)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112667/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic