From kstars-devel Sat Dec 28 22:17:28 2013 From: "Albert Astals Cid" Date: Sat, 28 Dec 2013 22:17:28 +0000 To: kstars-devel Subject: Re: [Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and defa Message-Id: <20131228221728.10653.79646 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kstars-devel&m=138826907716339 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6643577775749773128==" --===============6643577775749773128== Content-Type: multipart/alternative; boundary="===============2187626762471741662==" --===============2187626762471741662== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112496/#review46332 ----------------------------------------------------------- Vijay do you plan to address Rafal's comments? - Albert Astals Cid On Sept. 29, 2013, 6:22 a.m., Vijay Dhameliya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112496/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2013, 6:22 a.m.) > > > Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga. > > > Repository: kstars > > > Description > ------- > > In conjunctions tool default width of column in text box is set large enough to make it look better and column "object 2" is added to keep log of to which object the object 1 is mapping, when we have calculated many conjunctions from same object 1 to different object 2s. > > > Diffs > ----- > > kstars/kstarsinit.cpp a4393e6 > kstars/tools/conjunctions.h b51209e > kstars/tools/conjunctions.cpp 39cef00 > kstars/tools/conjunctions.ui 80374b1 > > Diff: https://git.reviewboard.kde.org/r/112496/diff/ > > > Testing > ------- > > tested > > > File Attachments > ---------------- > > > https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png > > https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png > > > Thanks, > > Vijay Dhameliya > > --===============2187626762471741662== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112496/

Vijay do you plan to address Rafal's comments?

- Albert Astals Cid

On September 29th, 2013, 6:22 a.m. UTC, Vijay Dhameliya wrote:

Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.

By Vijay Dhameliya.

Updated Sept. 29, 2013, 6:22 a.m.

Repository: kstars

Description

In conjunctions tool default width of column in text box is set large enough to make it look better and column "object 2" is added to keep log of to which object the object 1 is mapping,  when we have calculated many conjunctions from same object 1 to different object 2s.

Testing

tested

Diffs

kstars/kstarsinit.cpp (a4393e6)
kstars/tools/conjunctions.h (b51209e)
kstars/tools/conjunctions.cpp (39cef00)
kstars/tools/conjunctions.ui (80374b1)

View Diff

File Attachments

--===============2187626762471741662==-- --===============6643577775749773128== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kstars-devel mailing list Kstars-devel@kde.org https://mail.kde.org/mailman/listinfo/kstars-devel --===============6643577775749773128==--