This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113438/

This review has been submitted with commit dbef6b5eccf6268740231898f3d3a175f8af7f24 by Vijay Dhameliya to branch master.

- Commit Hook

On October 28th, 2013, 12:14 p.m. UTC, Vijay Dhameliya wrote:

Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.

By Vijay Dhameliya.

Updated Oct. 28, 2013, 12:14 p.m.

Bugs: 326647

Repository: kstars

Description

Bug:
->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
 
Fixing:
-> Drawing KSComet on the basis of Total Magnitude Parameter

Testing

Bug fixed - No more crashing

Diffs

kstars/dialogs/detaildialog.cpp (efda624)
kstars/skycomponents/cometscomponent.cpp (395c856)

View Diff