From kstars-devel Tue Dec 24 03:40:11 2013 From: "Commit Hook" Date: Tue, 24 Dec 2013 03:40:11 +0000 To: kstars-devel Subject: Re: [Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw() Message-Id: <20131224034011.4851.15642 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kstars-devel&m=138785642705699 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6833003576879438561==" --===============6833003576879438561== Content-Type: multipart/alternative; boundary="===============1759157870471923921==" --===============1759157870471923921== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113438/#review46107 ----------------------------------------------------------- This review has been submitted with commit dbef6b5eccf6268740231898f3d3a175f8af7f24 by Vijay Dhameliya to branch master. - Commit Hook On Oct. 28, 2013, 12:14 p.m., Vijay Dhameliya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113438/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 12:14 p.m.) > > > Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora. > > > Bugs: 326647 > http://bugs.kde.org/show_bug.cgi?id=326647 > > > Repository: kstars > > > Description > ------- > > Bug: > ->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object. > > Fixing: > -> Drawing KSComet on the basis of Total Magnitude Parameter > > > Diffs > ----- > > kstars/dialogs/detaildialog.cpp efda624 > kstars/skycomponents/cometscomponent.cpp 395c856 > > Diff: https://git.reviewboard.kde.org/r/113438/diff/ > > > Testing > ------- > > Bug fixed - No more crashing > > > Thanks, > > Vijay Dhameliya > > --===============1759157870471923921== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113438/

This review has been submitted with commit dbef6b5eccf6268740231898f3d3a175f8af7f24 by Vijay Dhameliya to branch master.

- Commit Hook

On October 28th, 2013, 12:14 p.m. UTC, Vijay Dhameliya wrote:

Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.

By Vijay Dhameliya.

Updated Oct. 28, 2013, 12:14 p.m.

Bugs: 326647

Repository: kstars

Description

Bug:
->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
 
Fixing:
-> Drawing KSComet on the basis of Total Magnitude Parameter

Testing

Bug fixed - No more crashing

Diffs

kstars/dialogs/detaildialog.cpp (efda624)
kstars/skycomponents/cometscomponent.cpp (395c856)

View Diff

--===============1759157870471923921==-- --===============6833003576879438561== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kstars-devel mailing list Kstars-devel@kde.org https://mail.kde.org/mailman/listinfo/kstars-devel --===============6833003576879438561==--