'Re: [Kstars-devel] Review Request 113325: Calling findMagnitude() from DetailDialog via public funct'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 113325: Calling findMagnitude() from DetailDialog via public funct
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-12-24 3:08:43
Message-ID: 20131224030843.4851.27141 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113325/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 3:08 a.m.)

Status
------

This change has been marked as submitted.

Review request for KStars, Akarsh Simha, Rafal Kulaga, and Rishab Arora.

Repository: kstars

Description
-------

Strange thing is findMagnitude() function from moon object is never called in Kstars \
even though its implementation is correct and yields correct magnitude of moon \
according to wikipedia.  The public method updateMag() can be called from anywhere in \
Kstars to set magnitude in Moon object and it is called from class DetailDialog to \
saw magnitude in detail dialog widget.  Many skyobject like Saturn and some stars the \
magnitude is always in hundredth decimal place so it is better to set magnitude to \
hundredth decimal place in class DetailDialog. 

Diffs
-----

  kstars/dialogs/detaildialog.cpp 7eabb9c 
  kstars/skyobjects/ksmoon.h 559d203 

Diff: https://git.reviewboard.kde.org/r/113325/diff/

Testing
-------

Integer digits of magnitude being calculated matches to that given on Wikipedia for \
all phases 

File Attachments
----------------

moon_detail_before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/e2e4721f-607b-40c4-b3aa-f2787002a873__moon_detail_before.png
 moon_detail_after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/13d80941-59f1-4ab5-83f4-858153f3263a__moon_detail_after.png

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/113325/">https://git.reviewboard.kde.org/r/113325/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars, Akarsh Simha, Rafal Kulaga, and Rishab Arora.</div>
<div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2013, 3:08 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Strange thing is findMagnitude() function from moon object is never \
called in Kstars even though its implementation is correct and yields correct \
magnitude of moon according to wikipedia.  The public method updateMag() can be \
called from anywhere in Kstars to set magnitude in Moon object and it is called from \
class DetailDialog to saw magnitude in detail dialog widget.  Many skyobject like \
Saturn and some stars the magnitude is always in hundredth decimal place so it is \
better to set magnitude to hundredth decimal place in class DetailDialog. </pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Integer digits of magnitude being calculated matches to that given on \
Wikipedia for all phases </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/dialogs/detaildialog.cpp <span style="color: grey">(7eabb9c)</span></li>

 <li>kstars/skyobjects/ksmoon.h <span style="color: grey">(559d203)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/113325/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/e2e4721f \
-607b-40c4-b3aa-f2787002a873__moon_detail_before.png">moon_detail_before.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/13d80941 \
-59f1-4ab5-83f4-858153f3263a__moon_detail_after.png">moon_detail_after.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 