'Re: [Kstars-devel] Review Request 114348: Correct parsing of google image search file for images in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 114348: Correct parsing of google image search file for images in
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-12-24 3:05:23
Message-ID: 20131224030523.4851.83355 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114348/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 3:05 a.m.)

Status
------

This change has been marked as submitted.

Review request for KStars and Rafal Kulaga.

Repository: kstars

Description
-------

Issue: while clicking on thumbnail of image in detail dialogue box of skyobject who \
does not have any picture link in database does not download images from Google due \
to wrong method of parsing. 

Diffs
-----

  kstars/thumbnailpicker.cpp d3b3cce 

Diff: https://git.reviewboard.kde.org/r/114348/diff/

Testing
-------

Downloaded images are very small in size but small images instead of nothing are \
better :) 

File Attachments
----------------

comet_image_loader.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/07/12a171be-c942-4cec-9ff7-5e532a59e192__comet_image_loader.png

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114348/">https://git.reviewboard.kde.org/r/114348/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2013, 3:05 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Issue: while clicking on thumbnail of image in detail dialogue box of \
skyobject who does not have any picture link in database does not download images \
from Google due to wrong method of parsing. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Downloaded images are very small in size but small images instead of \
nothing are better :) </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/thumbnailpicker.cpp <span style="color: grey">(d3b3cce)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114348/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/07/12a171be \
-c942-4cec-9ff7-5e532a59e192__comet_image_loader.png">comet_image_loader.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 