'Re: [Kstars-devel] Review Request 112994: Enhancing labeling in skycalender'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 112994: Enhancing labeling in skycalender
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-11-12 18:06:15
Message-ID: 20131112180615.18433.34639 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112994/
-----------------------------------------------------------

(Updated Nov. 12, 2013, 6:06 p.m.)

Status
------

This change has been marked as submitted.

Review request for KStars, Henry de Valence and Rafal Kulaga.

Repository: kstars

Description
-------

Currently SkyCalender doesn't label all the lines. 
New algorithm for labeling labels all the lines and for very small lines on hovering \
at beginning of line will popup label 

PS: I have submitted the same commit before but there occurred some error when I made \
attempt to update diff file

Diffs
-----

  kstars/tools/skycalendar.cpp 3ca61de 

Diff: http://git.reviewboard.kde.org/r/112994/diff/

Testing
-------

File Attachments
----------------

Venus_Kolkata_After.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/3a0e2b4c-0d08-48c6-8c99-e133fc0f05f7__Venus_Kolkata_After.png
 Venus_Kolkata_Before.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/7650ee80-076e-44d7-97c0-9d654f7a409c__Venus_Kolkata_Before.png
 Neptune_Klamath_Fall_Before.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/23807752-aed3-446f-848d-23de358af6de__Neptune_Klamath_Fall_Before.png
 Neptune_Klamath_Fall_After.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/d33c3503-b320-406f-af89-aaca97cd3f58__Neptune_Klamath_Fall_After.png

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112994/">http://git.reviewboard.kde.org/r/112994/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars, Henry de Valence and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Nov. 12, 2013, 6:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently SkyCalender doesn&#39;t label all the lines.  New algorithm \
for labeling labels all the lines and for very small lines on hovering at beginning \
of line will popup label 

PS: I have submitted the same commit before but there occurred some error when I made \
attempt to update diff file</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/tools/skycalendar.cpp <span style="color: grey">(3ca61de)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112994/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/3a0e2b4c- \
0d08-48c6-8c99-e133fc0f05f7__Venus_Kolkata_After.png">Venus_Kolkata_After.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/7650ee80- \
076e-44d7-97c0-9d654f7a409c__Venus_Kolkata_Before.png">Venus_Kolkata_Before.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/23807752- \
aed3-446f-848d-23de358af6de__Neptune_Klamath_Fall_Before.png">Neptune_Klamath_Fall_Before.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/30/d33c3503- \
b320-406f-af89-aaca97cd3f58__Neptune_Klamath_Fall_After.png">Neptune_Klamath_Fall_After.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 