'Re: [Kstars-devel] Review Request 113394: Setting alt/az from ra/dec for supernova object while load'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 113394: Setting alt/az from ra/dec for supernova object while load
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-11-11 21:50:42
Message-ID: 20131111215042.24706.90924 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113394/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 9:50 p.m.)

Status
------

This change has been marked as submitted.

Review request for KStars, Samikshan Bairagya, Henry de Valence, and Rafal Kulaga.

Bugs: 326466
    http://bugs.kde.org/show_bug.cgi?id=326466

Repository: kstars

Description
-------

While loading data from file, only ra/dec for supernova object are set which leads in \
error when alt/az of constellation objects are used without call to \
SkyPoint:EquatorialToHorizontal() (attached bug is one example in which \
skyObject->alt().radians() is called from Projector::toScreenVec() and alt for \
supernovae is not set yet so it leads to error). To avoid such scenario alt/az of \
supernova object are set while loading it to SupernovaeComponent.

Removed unused variables line and fields. 

Diffs
-----

  kstars/skycomponents/supernovaecomponent.cpp 157b319 

Diff: http://git.reviewboard.kde.org/r/113394/diff/

Testing
-------

Bug fixed

File Attachments
----------------

supernovae_bug.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/d32a12e2-cd06-4db3-b7e2-9687c4b264cc__supernovae_bug.png
 supernovae_bug_fixed.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/d390eb44-9058-41e5-9640-3ea39f1bf679__supernovae_bug_fixed.png

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113394/">http://git.reviewboard.kde.org/r/113394/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars, Samikshan Bairagya, Henry de Valence, and Rafal \
Kulaga.</div> <div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Nov. 11, 2013, 9:50 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=326466">326466</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While loading data from file, only ra/dec for supernova object are set \
which leads in error when alt/az of constellation objects are used without call to \
SkyPoint:EquatorialToHorizontal() (attached bug is one example in which \
skyObject-&gt;alt().radians() is called from Projector::toScreenVec() and alt for \
supernovae is not set yet so it leads to error). To avoid such scenario alt/az of \
supernova object are set while loading it to SupernovaeComponent.

Removed unused variables line and fields. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug fixed</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: \
grey">(157b319)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113394/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/d32a12e2-cd06-4db3-b7e2-9687c4b264cc__supernovae_bug.png">supernovae_bug.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/d390eb44- \
9058-41e5-9640-3ea39f1bf679__supernovae_bug_fixed.png">supernovae_bug_fixed.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 