'Re: [Kstars-devel] Review Request 112460: Label all lines in Sky Calendar'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 112460: Label all lines in Sky Calendar
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-09-29 6:23:07
Message-ID: 20130929062307.8269.91832 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112460/
-----------------------------------------------------------

(Updated Sept. 29, 2013, 6:23 a.m.)

Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.

Description
-------

Issue: Label are appearing only on graph of rise, set and transit time vs days in \
night time region i.e. some lines still don't get labelled.

Solved: Label will appear on each separated line object in graph and some time label \
is there on graph but it has gone outside so can be seen by hovering over starting or \
ending point of line. 

Diffs
-----

  kstars/skyobjects/skypoint.cpp f634075 
  kstars/tools/skycalendar.cpp 3ca61de 

Diff: http://git.reviewboard.kde.org/r/112460/diff/

Testing
-------

Tested and works fine

File Attachments
----------------

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Venus_Kolkata_After.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Venus_Kolkata_Before.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Neptune_Klamath_Fall_After.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Neptune_Klamath_Fall_Before.png

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112460/">http://git.reviewboard.kde.org/r/112460/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
Kulaga.</div> <div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2013, 6:23 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Issue: Label are appearing only on graph of rise, set and transit time \
vs days in night time region i.e. some lines still don&#39;t get labelled.

Solved: Label will appear on each separated line object in graph and some time label \
is there on graph but it has gone outside so can be seen by hovering over starting or \
ending point of line. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and works fine</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skyobjects/skypoint.cpp <span style="color: grey">(f634075)</span></li>

 <li>kstars/tools/skycalendar.cpp <span style="color: grey">(3ca61de)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112460/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Venus_Kolkata_After.png">Venus_Kolkata_After.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Venus_Kolkata_Before.png">Venus_Kolkata_Before.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Neptune_Klamath_Fall_After.png">Neptune_Klamath_Fall_After.png</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Neptune_Klamath_Fall_Before.png">Neptune_Klamath_Fall_Before.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 