[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: [Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and defa
From: "Rafal Kulaga" <rl.kulaga () gmail ! com>
Date: 2013-09-14 21:17:17
Message-ID: 20130914211717.25212.78261 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112496/#review40031
-----------------------------------------------------------
Comments below. With this configuration of the view, it is not possible to change the \
width of the "Object 2" section - this should be fixed.
kstars/tools/conjunctions.h
<http://git.reviewboard.kde.org/r/112496/#comment29634>
Please use const references and fix whitespaces.
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29635>
I wonder if "Date & Time" wouldn't be better...
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29636>
Again, WS fix and const references please.
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29637>
Stray WS.
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29638>
Stray WS
- Rafal Kulaga
On Sept. 13, 2013, 10:56 p.m., Vijay Dhameliya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112496/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 10:56 p.m.)
>
>
> Review request for KStars and Akarsh Simha.
>
>
> Description
> -------
>
> In conjunctions tool default width of column in text box is set large enough to \
> make it look better and column "object 2" is added to keep log of to which object \
> the object 1 is mapping, when we have calculated many conjunctions from same \
> object 1 to different object 2s.
>
> Diffs
> -----
>
> kstars/tools/conjunctions.cpp 39cef00
> kstars/tools/conjunctions.h b51209e
> kstars/tools/conjunctions.ui 80374b1
>
> Diff: http://git.reviewboard.kde.org/r/112496/diff/
>
>
> Testing
> -------
>
> tested
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png
>
>
> Thanks,
>
> Vijay Dhameliya
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112496/">http://git.reviewboard.kde.org/r/112496/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Comments below. With \
this configuration of the view, it is not possible to change the width of the \
"Object 2" section - this should be fixed.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/4/?file=189401#file189401line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">73</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">showConjunctions</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QMap</span><span \
class="o"><</span><span class="kt">long</span> <span class="kt">double</span><span \
class="p">,</span> <span class="n">dms</span><span class="o">></span> <span \
class="o">&</span><span class="n">conjunctionlist</span><span class="p">,</span> \
<span class="n">QString</span> <span class="n">object</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">73</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span \
class="nf">showConjunctions</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QMap</span><span class="o"><</span><span \
class="kt">long</span> <span class="kt">double</span><span class="p">,</span> <span \
class="n">dms</span><span class="o">></span> <span class="o">&</span><span \
class="n">conjunctionlist</span><span class="p">,</span> <span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span class="n">QString</span> \
<span class="n">object<span class="hl">1</span></span><span class="hl"> </span><span \
class="p"><span class="hl">,</span></span><span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QString</span></span><span class="hl"> </span><span class="n"><span \
class="hl">object2</span></span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use \
const references and fix whitespaces.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402line108" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ConjunctionsTool::ConjunctionsTool(QWidget *parentSplit)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">108</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Date && Time (UT)"</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Object"</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Separation"</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">108</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="o"><<</span> \
<span class="n">i18n</span><span class="p">(</span> <span class="s">"Date \
&& Time (UT)"</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Object<span class="hl"> 1"</span></span><span class="hl"> \
</span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span \
class="o"><span class="hl"><<</span></span><span class="hl"> </span><span \
class="n"><span class="hl">i18n</span></span><span class="p"><span \
class="hl">(</span></span><span class="hl"> </span><span class="s"><span \
class="hl">"Object 2</span>"</span> <span class="p">)</span> <span \
class="o"><<</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Separation"</span> <span class="p">)</span> <span cla \
ss="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder if \
"Date & Time" wouldn't be better...</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402line371" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::slotCompute (void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">371</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> \
<span class="n">ConjunctionsTool</span><span class="o">::</span><span \
class="n">showConjunctions</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QMap</span><span class="o"><</span><span class="kt">long</span> \
<span class="kt">double</span><span class="p">,</span> <span \
class="n">dms</span><span class="o">></span> <span class="o">&</span><span \
class="n">conjunctionlist</span><span class="p">,</span> <span \
class="n">QString</span> <span class="n">object</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">371</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span \
class="n">ConjunctionsTool</span><span class="o">::</span><span \
class="n">showConjunctions</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QMap</span><span class="o"><</span><span class="kt">long</span> \
<span class="kt">double</span><span class="p">,</span> <span \
class="n">dms</span><span class="o">></span> <span class="o">&</span><span \
class="n">conjunctionlist</span><span class="p">,</span><span class="k"><span \
class="hl">const</span></span> <span class="n">QString</span> <span \
class="n">object<span class="hl">1</span></span><span class="p"><span \
class="hl">,</span></span><span class="k"><span class="hl">const</span></span><span \
class="hl"> </span><span class="n"><span class="hl">QString</span></span><span \
class="hl"> </span><span class="n"><span class="hl">object2</span></span><span \
class="p">)</span></pre ></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again, WS \
fix and const references please.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402line386" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist, QString object)</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist,const QString object1,const QString object2)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">386</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">itemList</span> <span class="o"><<</span> <span \
class="n">typeItem</span><span class="ew"> </span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">386</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">itemList</span> <span class="o"><<</span> <span \
class="n">typeItem</span><span class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stray \
WS.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402line387" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist, QString object)</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist,const QString object1,const QString object2)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">387</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="k">new</span> <span \
class="n">QStandardItem</span><span class="p">(</span> <span \
class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span \
class="p">()</span><span class="o">-></span><span \
class="n">formatDateTime</span><span class="p">(</span> <span \
class="n">dt</span><span class="p">,</span> <span class="n">KLocale</span><span \
class="o">::</span><span class="n">IsoDate</span> <span class="p">)</span> <span \
class="p">)</span><span class="ew"> </span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">387</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="k">new</span> <span \
class="n">QStandardItem</span><span class="p">(</span> <span \
class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span \
class="p">()</span><span class="o">-></span><span \
class="n">formatDateTime</span><span class="p">(</span> <span \
class="n">dt</span><span class="p">,</span> <span class="n">KLocale</span><span \
class="o">::</span><span class="n">IsoDate</span> <span class="p">)</span> <span \
class="p">)</span><span class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stray \
WS</pre> </div>
<br />
<p>- Rafal</p>
<br />
<p>On September 13th, 2013, 10:56 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KStars and Akarsh Simha.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2013, 10:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In conjunctions tool default width of column in text box is set large \
enough to make it look better and column "object 2" is added to keep log of \
to which object the object 1 is mapping, when we have calculated many conjunctions \
from same object 1 to different object 2s.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(39cef00)</span></li>
<li>kstars/tools/conjunctions.h <span style="color: grey">(b51209e)</span></li>
<li>kstars/tools/conjunctions.ui <span style="color: grey">(80374b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112496/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png">Conjunction_tool_after.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png">Conjunction_tool_Before.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic