[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: [Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and defa
From: "Rafal Kulaga" <rl.kulaga () gmail ! com>
Date: 2013-09-13 22:01:22
Message-ID: 20130913220122.29418.32867 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112496/#review39997
-----------------------------------------------------------
This is definitely a nice usability improvement. I have marked a few comments in the \
diff. Could you please look at them?
Thanks!
kstars/tools/conjunctions.h
<http://git.reviewboard.kde.org/r/112496/#comment29550>
It would make sense to use a const reference here instead of passing those \
QStrings by value. Also, I would name those arguments object1 and object2, just to be \
consistent with the rest of the code.
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29559>
A wild whitespace appeared after "object".
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29562>
Again, WS issues.
kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29565>
Again, maybe using object1 would be more consistent.
- Rafal Kulaga
On Sept. 4, 2013, 8:11 p.m., Vijay Dhameliya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112496/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 8:11 p.m.)
>
>
> Review request for KStars and Akarsh Simha.
>
>
> Description
> -------
>
> In conjunctions tool default width of column in text box is set large enough to \
> make it look better and column "object 2" is added to keep log of to which object \
> the object 1 is mapping, when we have calculated many conjunctions from same \
> object 1 to different object 2s.
>
> Diffs
> -----
>
> kstars/tools/conjunctions.h b51209e
> kstars/tools/conjunctions.cpp 39cef00
> kstars/tools/conjunctions.ui 80374b1
>
> Diff: http://git.reviewboard.kde.org/r/112496/diff/
>
>
> Testing
> -------
>
> tested
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png
>
>
> Thanks,
>
> Vijay Dhameliya
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112496/">http://git.reviewboard.kde.org/r/112496/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is definitely a \
nice usability improvement. I have marked a few comments in the diff. Could you \
please look at them?
Thanks!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/3/?file=187033#file187033line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.h</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">73</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">showConjunctions</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QMap</span><span \
class="o"><</span><span class="kt">long</span> <span class="kt">double</span><span \
class="p">,</span> <span class="n">dms</span><span class="o">></span> <span \
class="o">&</span><span class="n">conjunctionlist</span><span class="p">,</span> \
<span class="n">QString</span> <span class="n">object</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">73</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span \
class="nf">showConjunctions</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QMap</span><span class="o"><</span><span \
class="kt">long</span> <span class="kt">double</span><span class="p">,</span> <span \
class="n">dms</span><span class="o">></span> <span class="o">&</span><span \
class="n">conjunctionlist</span><span class="p">,</span> <span \
class="n">QString</span> <span class="n">object</span><span class="hl"> </span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="hl"> </span><span \
class="n"><span class="hl">object2</span></span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It would \
make sense to use a const reference here instead of passing those QStrings by value. \
Also, I would name those arguments object1 and object2, just to be consistent with \
the rest of the code.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/3/?file=187034#file187034line347" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::slotCompute (void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">347</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">showConjunctions</span><span class="p">(</span> <span \
class="n">ksc</span><span class="p">.</span><span \
class="n">findClosestApproach</span><span class="p">(</span><span \
class="o">*</span><span class="n">Object1</span><span class="p">,</span> <span \
class="o">*</span><span class="n">Object2</span><span class="p">,</span> <span \
class="n">startJD</span><span class="p">,</span> <span class="n">stopJD</span><span \
class="p">,</span> <span class="n">maxSeparation</span><span class="p">,</span> <span \
class="n">opposition</span><span class="p">),</span> <span class="n">object</span> \
<span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">347</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">showConjunctions</span><span class="p">(</span> <span \
class="n">ksc</span><span class="p">.</span><span \
class="n">findClosestApproach</span><span class="p">(</span><span \
class="o">*</span><span class="n">Object1</span><span class="p">,</span> <span \
class="o">*</span><span class="n">Object2</span><span class="p">,</span> <span \
class="n">startJD</span><span class="p">,</span> <span class="n">stopJD</span><span \
class="p">,</span> <span class="n">maxSeparation</span><span class="p">,</span> <span \
class="n">opposition</span><span class="p">),</span> <span class="n">object</span> \
<span class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="n"><span class="hl">Object2</span></span><span class="o"><span \
class="hl">-></span></span><span class="n"><span \
class="hl">name</span></span><span class="p"><span class="hl">()</span></span><spa n \
class="hl"> </span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A wild \
whitespace appeared after "object".</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/3/?file=187034#file187034line356" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::slotCompute (void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">356</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">showConjunctions</span><span class="p">(</span> <span \
class="n">ksc</span><span class="p">.</span><span \
class="n">findClosestApproach</span><span class="p">(</span><span \
class="o">*</span><span class="n">Object1</span><span class="p">,</span> <span \
class="o">*</span><span class="n">Object2</span><span class="p">,</span> <span \
class="n">startJD</span><span class="p">,</span> <span class="n">stopJD</span><span \
class="p">,</span> <span class="n">maxSeparation</span><span class="p">,</span> <span \
class="n">opposition</span><span class="p">),</span> <span \
class="n">Object1</span><span class="o">-></span><span class="n">name</span><span \
class="p">()</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">356</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">showConjunctions</span><span class="p">(</span> <span \
class="n">ksc</span><span class="p">.</span><span \
class="n">findClosestApproach</span><span class="p">(</span><span \
class="o">*</span><span class="n">Object1</span><span class="p">,</span> <span \
class="o">*</span><span class="n">Object2</span><span class="p">,</span> <span \
class="n">startJD</span><span class="p">,</span> <span class="n">stopJD</span><span \
class="p">,</span> <span class="n">maxSeparation</span><span class="p">,</span> <span \
class="n">opposition</span><span class="p">),</span> <span \
class="n">Object1</span><span class="o">-></span><span class="n">name</span><span \
class="p">()<span class="hl">,</span></span><span class="n"><span \
class="hl">Object2</span></span><span class="o"><span \
class="hl">-></span></span><span class="n"><span \
class="hl">name</span></span><span class="p"><span cla ss="hl">()</span></span> \
<span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again, WS \
issues.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112496/diff/3/?file=187034#file187034line388" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist, QString object)</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist, QString object, QString object2)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">388</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="k">new</span> <span \
class="n">QStandardItem</span><span class="p">(</span> <span class="n">object</span> \
<span class="p">)</span><span class="ew"> </span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">388</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="k">new</span> <span \
class="n">QStandardItem</span><span class="p">(</span> <span class="n">object</span> \
<span class="p">)</span><span class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again, \
maybe using object1 would be more consistent.</pre> </div>
<br />
<p>- Rafal</p>
<br />
<p>On September 4th, 2013, 8:11 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KStars and Akarsh Simha.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2013, 8:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In conjunctions tool default width of column in text box is set large \
enough to make it look better and column "object 2" is added to keep log of \
to which object the object 1 is mapping, when we have calculated many conjunctions \
from same object 1 to different object 2s.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/conjunctions.h <span style="color: grey">(b51209e)</span></li>
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(39cef00)</span></li>
<li>kstars/tools/conjunctions.ui <span style="color: grey">(80374b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112496/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png">Conjunction_tool_after.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png">Conjunction_tool_Before.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic