[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: [Kstars-devel] Review Request: My entire GSoC work till now. What's Interesting works for planet
From: "Akarsh Simha" <akarshsimha () gmail ! com>
Date: 2012-07-13 15:33:26
Message-ID: 20120713153326.14434.16810 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105481/#review15549
-----------------------------------------------------------
Here's few comments. More will come later.
kstars/data/PlanetFacts.dat
<http://git.reviewboard.kde.org/r/105481/#comment12156>
Where did you get these facts from? If you wrote them yourself, perfect=
. If you got them from somewhere, we should check that the source is compat=
ible with GPL, and cite it with appropriate credit / copyright.
kstars/indi/indielement.h
<http://git.reviewboard.kde.org/r/105481/#comment12157>
Eh?
kstars/kstarsactions.cpp
<http://git.reviewboard.kde.org/r/105481/#comment12152>
How is the deletion of wi to free up space later managed? Maybe you sho=
uld do something similar to what is done for WUTDialog just above.
kstars/kstarsui-indi.rc
<http://git.reviewboard.kde.org/r/105481/#comment12154>
Indent
kstars/kstarsui-win.rc
<http://git.reviewboard.kde.org/r/105481/#comment12155>
Indent
kstars/kstarsui.rc
<http://git.reviewboard.kde.org/r/105481/#comment12153>
Indent
kstars/tools/WhatsInteresting/WIView.cpp
<http://git.reviewboard.kde.org/r/105481/#comment12158>
Eh???
- Akarsh Simha
On July 8, 2012, 5:55 p.m., Samikshan Bairagya wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105481/
> -----------------------------------------------------------
> =
> (Updated July 8, 2012, 5:55 p.m.)
> =
> =
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> =
> =
> Description
> -------
> =
> QML user interface for testing purpose ready. This shows planets, bright =
stars, constellations and deep-sky object. Description not yet available fo=
r bright stars and constellations. The details-view is not ready for DSOs. =
Also the list of DSOs displayed is not the filtered or interesting list.
> =
> =
> Diffs
> -----
> =
> kstars/CMakeLists.txt 1113333 =
> kstars/data/CMakeLists.txt 0dc591b =
> kstars/data/Interesting.dat PRE-CREATION =
> kstars/data/PlanetFacts.dat PRE-CREATION =
> kstars/data/initWIList.dat PRE-CREATION =
> kstars/indi/indielement.h 93be2ba =
> kstars/kstars.h 959f042 =
> kstars/kstarsactions.cpp e2f8fc5 =
> kstars/kstarsinit.cpp bbc70fe =
> kstars/kstarsui-indi.rc d2bbdb0 =
> kstars/kstarsui-win.rc 20a2fa0 =
> kstars/kstarsui.rc 1f28415 =
> kstars/tools/WhatsInteresting/Base.qml PRE-CREATION =
> kstars/tools/WhatsInteresting/CMakeLists.txt PRE-CREATION =
> kstars/tools/WhatsInteresting/WIView.h PRE-CREATION =
> kstars/tools/WhatsInteresting/WIView.cpp PRE-CREATION =
> kstars/tools/WhatsInteresting/modelmanager.h PRE-CREATION =
> kstars/tools/WhatsInteresting/modelmanager.cpp PRE-CREATION =
> kstars/tools/WhatsInteresting/skyobjitem.h PRE-CREATION =
> kstars/tools/WhatsInteresting/skyobjitem.cpp PRE-CREATION =
> kstars/tools/WhatsInteresting/skyobjlistmodel.h PRE-CREATION =
> kstars/tools/WhatsInteresting/skyobjlistmodel.cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/105481/diff/
> =
> =
> Testing
> -------
> =
> Testing done for planets, constellations, bright stars. Details-view not =
yet ready for DSOs.
> =
> =
> Thanks,
> =
> Samikshan Bairagya
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105481/">http://git.reviewboard.kde.org/r/105481/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here's few comments. \
More will come later.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71809#file71809line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/data/PlanetFacts.dat</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Mercury::Mercury is the innermost of the eight planets in the Solar System. It is \
also the smallest, and its orbit has the highest eccentricity of the eight. It orbits \
the Sun once in about 88 Earth days, completing three rotations about its axis for \
every two orbits. Mercury has the smallest axial tilt of the Solar System planets. \
The perihelion of Mercury's orbit precesses around the Sun at an excess of 43 \
arcseconds per century beyond what is predicted by Newtonian mechanics, a phenomenon \
that was explained in the 20th century by Albert Einstein's General Theory of \
Relativity. Mercury, being an inferior planet, appears as a morning star and an \
evening star, but is much more difficult to see than the other inferior planet, \
Venus. At its brightest, Mercury is technically a very bright object when viewed from \
Earth, but it is not easily seen in practice because of its proximity in the sky to \
the Sun.</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where did \
you get these facts from? If you wrote them yourself, perfect. If you got them from \
somewhere, we should check that the source is compatible with GPL, and cite it with \
appropriate credit / copyright.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71811#file71811line47" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/indi/indielement.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">47</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">/* new \
versions of glibc define TIME_UTC as a macro */</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eh?</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71813#file71813line288" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/kstarsactions.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void KStars::slotWI() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">288</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">wi</span> <span class="o">=</span> <span class="k">new</span> <span \
class="n">WIView</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How is the \
deletion of wi to free up space later managed? Maybe you should do something similar \
to what is done for WUTDialog just above.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71815#file71815line77" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/kstarsui-indi.rc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">77</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<Action name="whats_interesting" /></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Indent</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71816#file71816line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/kstarsui-win.rc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<Action name="whats_interesting" /></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Indent</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71817#file71817line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/kstarsui.rc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">69</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<Action name="whats_interesting" /></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Indent</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105481/diff/1/?file=71821#file71821line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/WhatsInteresting/WIView.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">WIView::WIView ( QObject *parent) : QObject(parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">baseView</span><span class="o">-></span><span \
class="n">setSource</span><span class="p">(</span><span class="n">QUrl</span><span \
class="p">(</span><span \
class="s">"/home/sam/kstars/kstars/tools/WhatsInteresting/Base.qml"</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eh???</pre> \
</div> <br />
<p>- Akarsh</p>
<br />
<p>On July 8th, 2012, 5:55 p.m., Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated July 8, 2012, 5:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QML user interface for testing purpose ready. This shows planets, bright \
stars, constellations and deep-sky object. Description not yet available for bright \
stars and constellations. The details-view is not ready for DSOs. Also the list of \
DSOs displayed is not the filtered or interesting list.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing done for planets, constellations, bright stars. Details-view not \
yet ready for DSOs.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(1113333)</span></li>
<li>kstars/data/CMakeLists.txt <span style="color: grey">(0dc591b)</span></li>
<li>kstars/data/Interesting.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/data/PlanetFacts.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/data/initWIList.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/indi/indielement.h <span style="color: grey">(93be2ba)</span></li>
<li>kstars/kstars.h <span style="color: grey">(959f042)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(e2f8fc5)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(bbc70fe)</span></li>
<li>kstars/kstarsui-indi.rc <span style="color: grey">(d2bbdb0)</span></li>
<li>kstars/kstarsui-win.rc <span style="color: grey">(20a2fa0)</span></li>
<li>kstars/kstarsui.rc <span style="color: grey">(1f28415)</span></li>
<li>kstars/tools/WhatsInteresting/Base.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/WIView.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/WIView.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/modelmanager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/modelmanager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/skyobjitem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/skyobjitem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/skyobjlistmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/tools/WhatsInteresting/skyobjlistmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105481/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic