'Re: [Kstars-devel] Review Request: Display faint stars in OpenGL backend'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request: Display faint stars in OpenGL backend
From:       "Akarsh Simha" <akarshsimha () gmail ! com>
Date:       2012-07-04 12:30:40
Message-ID: 20120704123040.13544.83190 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On July 4, 2012, 12:30 p.m., Akarsh Simha wrote:
> > Ship It!

Make sure it works.

- Akarsh

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104387/#review15368
-----------------------------------------------------------

On March 23, 2012, 3:21 p.m., Rishab Arora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104387/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 3:21 p.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> Removed condition in SkyGLPainter::addItem to ignore points with width less than \
> 1.5 Reason:
> SkyPainter::starWidth already contains a condition according to which the stars \
> that are too faint are allotted a width of 1.0 
> 
> This addresses bug 266928.
> http://bugs.kde.org/show_bug.cgi?id=266928
> 
> 
> Diffs
> -----
> 
> kstars/skyglpainter.cpp 2a74af9 
> 
> Diff: http://git.reviewboard.kde.org/r/104387/diff/
> 
> 
> Testing
> -------
> 
> 1. View any region with QPainter Backend.
> 2. Switch backend to OpenGL and compare.
> 
> Matched output with QPainter backend for all projections. No missing stars anymore \
> at any zoom level. 
> 
> Thanks,
> 
> Rishab Arora
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104387/">http://git.reviewboard.kde.org/r/104387/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 4th, 2012, 12:30 p.m., <b>Akarsh Simha</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship \
It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make sure it \
works.</pre> <br />

<p>- Akarsh</p>

<br />
<p>On March 23rd, 2012, 3:21 p.m., Rishab Arora wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Rishab Arora.</div>

<p style="color: grey;"><i>Updated March 23, 2012, 3:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed condition in SkyGLPainter::addItem to ignore points with width \
less than 1.5 Reason:
SkyPainter::starWidth already contains a condition according to which the stars that \
are too faint are allotted a width of 1.0</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. View any region with QPainter Backend. 2. Switch backend to OpenGL \
and compare.

Matched output with QPainter backend for all projections. No missing stars anymore at \
any zoom level.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=266928">266928</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skyglpainter.cpp <span style="color: grey">(2a74af9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104387/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 