[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: [Kstars-devel] Review Request: Fix dissapearing Milky Way at high zoomlevel on QPainter
From: Henry de Valence <hdevalence () gmail ! com>
Date: 2012-03-23 21:33:42
Message-ID: CAOnR5UpM8zFYvW28nVeRL37WO4X7af=HiydJXHJ1yxkx+Q9_1w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
FYI, the reason that the clipping was done manually was because there are
issues with some projections, and the fact that QPainter's clipping is
meant for flat objects, while this is doing clipping in spherical
coordinates, clipping along great-circle arcs instead of straight lines.
When I was refactoring the code into the two painting backends, I tried
just using QPainter's clipping, but there were regressions. Maybe it works
now -- but did you check all of the projections?
Cheers,
Henry de Valence
P.S. I realize it would be better if I commented on the reviewboard, but I
don't have an account, so I'm mailing here.
On Sun, Mar 18, 2012 at 03:43, Rishab Arora <ra.rishab@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104320/
>
> On March 18th, 2012, 12:11 a.m., *Rafal Kulaga* wrote:
>
> This patch indeed fixes the problem, but I wonder if the clipping here is needed at \
> all? It seems that we can get rid of it.
> I think so too! And that is what I wanted to confirm if we get any advantage at all \
> from ignoring points manually instead of painters perform the clipping themselves. \
> Attached p3.patch which works on both backends on the same principle.
>
> - Rishab
>
> On March 17th, 2012, 11:12 p.m., Rishab Arora wrote:
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> By Rishab Arora.
>
> *Updated March 17, 2012, 11:12 p.m.*
> Description
>
> Fixes bug https://bugs.kde.org/show_bug.cgi?id=266929 for QPainter backend only.
> At high zoomlevel, the points leave the FOV and are ignored completely, whereas \
> their fill should not be. Used clipping in QPainter to fix bug.
>
> Testing
>
> Tested at various zoomlevels and resolutions. No issues found.
>
> *Bugs: * https://bugs.kde.org/show_bug.cgi?id=266929<http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=266929>
> Diffs
>
> - kstars/projections/projector.h (966d002)
> - kstars/projections/projector.cpp (e8c1aff)
> - kstars/skyqpainter.cpp (43f06e8)
>
> View Diff <http://git.reviewboard.kde.org/r/104320/diff/>
>
> _______________________________________________
> Kstars-devel mailing list
> Kstars-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kstars-devel
>
>
[Attachment #5 (text/html)]
FYI, the reason that the clipping was done manually was because there are issues with \
some projections, and the fact that QPainter's clipping is meant for flat \
objects, while this is doing clipping in spherical coordinates, clipping along \
great-circle arcs instead of straight lines.<br>
<br>When I was refactoring the code into the two painting backends, I tried just \
using QPainter's clipping, but there were regressions. Maybe it works now -- but \
did you check all of the projections?<br><br>Cheers,<br>
Henry de Valence<br><br>P.S. I realize it would be better if I commented on the \
reviewboard, but I don't have an account, so I'm mailing here.<br><br><div \
class="gmail_quote">On Sun, Mar 18, 2012 at 03:43, Rishab Arora <span \
dir="ltr"><<a href="mailto:ra.rishab@gmail.com">ra.rishab@gmail.com</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" \
width="100%"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104320/" \
target="_blank">http://git.reviewboard.kde.org/r/104320/</a> </td>
</tr>
</tbody></table>
<br>
</div><div class="im"><blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <p style="margin-top:0">On March 18th, 2012, 12:11 a.m., \
<b>Rafal Kulaga</b> wrote:</p> <blockquote style="margin-left:1em;border-left:2px \
solid #d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This \
patch indeed fixes the problem, but I wonder if the clipping here is needed at all? \
It seems that we can get rid of it.</pre>
</blockquote>
</blockquote>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I \
think so too! And that is what I wanted to confirm if we get any advantage at all \
from ignoring points manually instead of painters perform the clipping themselves. \
Attached p3.patch which works on both backends on the same principle.</pre>
<span class="HOEnZb"><font color="#888888">
<br>
<p>- Rishab</p></font></span><div class="im">
<br>
<p>On March 17th, 2012, 11:12 p.m., Rishab Arora wrote:</p>
<table style="background-image:url('');background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%"> \
<tbody><tr> <td>
<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Rishab Arora.</div>
<p style="color:grey"><i>Updated March 17, 2012, 11:12 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Fixes \
bug <a href="https://bugs.kde.org/show_bug.cgi?id=266929" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=266929</a> for QPainter backend \
only. At high zoomlevel, the points leave the FOV and are ignored completely, whereas \
their fill should not be. Used clipping in QPainter to fix bug.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Tested \
at various zoomlevels and resolutions. No issues found.</pre> </td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=266929" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=266929</a>
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kstars/projections/projector.h <span style="color:grey">(966d002)</span></li>
<li>kstars/projections/projector.cpp <span style="color:grey">(e8c1aff)</span></li>
<li>kstars/skyqpainter.cpp <span style="color:grey">(43f06e8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104320/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
<br>_______________________________________________<br>
Kstars-devel mailing list<br>
<a href="mailto:Kstars-devel@kde.org">Kstars-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kstars-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kstars-devel</a><br> \
<br></blockquote></div><br>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic