'[Kstars-devel] Review Request: Dialog for Supernova options.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    [Kstars-devel] Review Request: Dialog for Supernova options.
From:       "Samikshan Bairagya" <samikshan () gmail ! com>
Date:       2011-12-25 11:30:21
Message-ID: 20111225113021.10895.31576 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103530/
-----------------------------------------------------------

Review request for KStars, Rafal Kulaga and Akarsh Simha.

Description
-------

Worked on the problems of my earlier review request and fixed them. There's=
 no icon for Supernova now. Users can choose to either have or not have sup=
ernovae on their skymap. Notifications for new supernovae is not yet implem=
ented.

Diffs
-----

  kstars/kstarsactions.cpp 15d2552 =

  kstars/kstarsdcop.cpp c045e47 =

  kstars/options/opssupernovae.h PRE-CREATION =

  kstars/options/opssupernovae.cpp PRE-CREATION =

  kstars/options/opssupernovae.ui PRE-CREATION =

  kstars/CMakeLists.txt 6f7ed20 =

  kstars/kstars.h aa76633 =

  kstars/kstars.kcfg 986f322 =

  kstars/skycomponents/supernovaecomponent.h ab824c6 =

  kstars/skycomponents/supernovaecomponent.cpp 5c3c8bb =

Diff: http://git.reviewboard.kde.org/r/103530/diff/diff

Testing
-------

Thanks,

Samikshan Bairagya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103530/">http://git.reviewboard.kde.org/r/103530/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Worked on the problems of my earlier review request and fixed them. \
There&#39;s no icon for Supernova now. Users can choose to either have or not have \
supernovae on their skymap. Notifications for new supernovae is not yet \
implemented.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/kstarsactions.cpp <span style="color: grey">(15d2552)</span></li>

 <li>kstars/kstarsdcop.cpp <span style="color: grey">(c045e47)</span></li>

 <li>kstars/options/opssupernovae.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kstars/options/opssupernovae.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kstars/options/opssupernovae.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kstars/CMakeLists.txt <span style="color: grey">(6f7ed20)</span></li>

 <li>kstars/kstars.h <span style="color: grey">(aa76633)</span></li>

 <li>kstars/kstars.kcfg <span style="color: grey">(986f322)</span></li>

 <li>kstars/skycomponents/supernovaecomponent.h <span style="color: \
grey">(ab824c6)</span></li>

 <li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: \
grey">(5c3c8bb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103530/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 