[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: [Kstars-devel] Re: Review Request: Adding recent supernovae to
From: "Akarsh Simha" <akarshsimha () gmail ! com>
Date: 2011-07-28 6:48:57
Message-ID: 20110728064857.461.50915 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102091/#review5150
-----------------------------------------------------------
kstars/skycomponents/supernovaecomponent.cpp
<http://git.reviewboard.kde.org/r/102091/#comment4645>
Hmm, there's no check if this fails -- i.e. if python is not found, or =
the script was not run successfully, etc. Also, you might need to run pytho=
n in batch mode or something -- basically avoid interactive mode. It should=
just dropout whenever it encounters a syntax error. You should then report=
whether it failed or not.
- Akarsh
On July 27, 2011, 5:51 a.m., Samikshan Bairagya wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102091/
> -----------------------------------------------------------
> =
> (Updated July 27, 2011, 5:51 a.m.)
> =
> =
> Review request for KStars, Victor Carbune, Rafal Kulaga, and Akarsh Simha.
> =
> =
> Summary
> -------
> =
> This diff adds recently observed supernovae to KStars. Data is extracted =
from http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html using a py=
thon script.
> Data is stored in a CSV format. The supernovae are drawn on the skymap as=
small orange plus signs. Also Supernovae maybe found out by name from the =
Find =
> Object dialog.box. I have yet to write the SkyGLPainter::drawSupernova() =
method.
> =
> =
> Diffs
> -----
> =
> kstars/CMakeLists.txt 0c335b6 =
> kstars/colorscheme.cpp 9d669a1 =
> kstars/data/CMakeLists.txt 64493f0 =
> kstars/data/chart.colors 5515c1b =
> kstars/data/classic.colors 31e6706 =
> kstars/data/moonless-night.colors c1d3b06 =
> kstars/data/night.colors a31f69e =
> kstars/data/scripts/supernova_updates_parser.py 9833458 =
> kstars/kstars.h 6516f9e =
> kstars/kstars.kcfg 6d088d7 =
> kstars/kstarsactions.cpp e917cac =
> kstars/kstarsdata.cpp 2303c5f =
> kstars/kstarsinit.cpp 7f4471e =
> kstars/skycomponents/skymapcomposite.h adf496d =
> kstars/skycomponents/skymapcomposite.cpp 82fef8a =
> kstars/skycomponents/supernovaecomponent.h PRE-CREATION =
> kstars/skycomponents/supernovaecomponent.cpp PRE-CREATION =
> kstars/skyglpainter.h 2aa8d87 =
> kstars/skyglpainter.cpp 655d2c7 =
> kstars/skyobjects/skyobject.h 3a6122f =
> kstars/skyobjects/supernova.h PRE-CREATION =
> kstars/skyobjects/supernova.cpp PRE-CREATION =
> kstars/skypainter.h 1340568 =
> kstars/skyqpainter.h df7cc9b =
> kstars/skyqpainter.cpp 87719b2 =
> =
> Diff: http://git.reviewboard.kde.org/r/102091/diff
> =
> =
> Testing
> -------
> =
> Testing has been done with all colour schemes and in QPainter backend.
> =
> =
> Thanks,
> =
> Samikshan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102091/">http://git.reviewboard.kde.org/r/102091/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102091/diff/3/?file=30050#file30050line192" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/supernovaecomponent.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void SupernovaeComponent::updateDataFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">192</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">parser</span><span class="o">-></span><span \
class="n">execute</span><span class="p">(</span><span \
class="s">"python"</span><span class="p">,</span><span \
class="n">QStringList</span><span class="p">(</span><span \
class="n">filename</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, \
there's no check if this fails -- i.e. if python is not found, or the script was \
not run successfully, etc. Also, you might need to run python in batch mode or \
something -- basically avoid interactive mode. It should just dropout whenever it \
encounters a syntax error. You should then report whether it failed or not.</pre> \
</div> <br />
<p>- Akarsh</p>
<br />
<p>On July 27th, 2011, 5:51 a.m., Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KStars, Victor Carbune, Rafal Kulaga, and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated July 27, 2011, 5:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This diff adds recently observed supernovae to KStars. Data is extracted \
from http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html using a python \
script. Data is stored in a CSV format. The supernovae are drawn on the skymap as \
small orange plus signs. Also Supernovae maybe found out by name from the Find \
Object dialog.box. I have yet to write the SkyGLPainter::drawSupernova() \
method.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing has been done with all colour schemes and in QPainter \
backend.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(0c335b6)</span></li>
<li>kstars/colorscheme.cpp <span style="color: grey">(9d669a1)</span></li>
<li>kstars/data/CMakeLists.txt <span style="color: grey">(64493f0)</span></li>
<li>kstars/data/chart.colors <span style="color: grey">(5515c1b)</span></li>
<li>kstars/data/classic.colors <span style="color: grey">(31e6706)</span></li>
<li>kstars/data/moonless-night.colors <span style="color: \
grey">(c1d3b06)</span></li>
<li>kstars/data/night.colors <span style="color: grey">(a31f69e)</span></li>
<li>kstars/data/scripts/supernova_updates_parser.py <span style="color: \
grey">(9833458)</span></li>
<li>kstars/kstars.h <span style="color: grey">(6516f9e)</span></li>
<li>kstars/kstars.kcfg <span style="color: grey">(6d088d7)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(e917cac)</span></li>
<li>kstars/kstarsdata.cpp <span style="color: grey">(2303c5f)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(7f4471e)</span></li>
<li>kstars/skycomponents/skymapcomposite.h <span style="color: \
grey">(adf496d)</span></li>
<li>kstars/skycomponents/skymapcomposite.cpp <span style="color: \
grey">(82fef8a)</span></li>
<li>kstars/skycomponents/supernovaecomponent.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/skyglpainter.h <span style="color: grey">(2aa8d87)</span></li>
<li>kstars/skyglpainter.cpp <span style="color: grey">(655d2c7)</span></li>
<li>kstars/skyobjects/skyobject.h <span style="color: grey">(3a6122f)</span></li>
<li>kstars/skyobjects/supernova.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/skyobjects/supernova.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kstars/skypainter.h <span style="color: grey">(1340568)</span></li>
<li>kstars/skyqpainter.h <span style="color: grey">(df7cc9b)</span></li>
<li>kstars/skyqpainter.cpp <span style="color: grey">(87719b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102091/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic