'[Kstars-devel] Re: Review Request: This patch fixes the magnitude'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    [Kstars-devel] Re: Review Request: This patch fixes the magnitude
From:       "Akarsh Simha" <akarshsimha () gmail ! com>
Date:       2011-06-17 5:53:19
Message-ID: 20110617055319.14862.31445 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101650/#review3946
-----------------------------------------------------------

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3222>

    Hmm, why not the if( !ok ) approach? If string conversion fails, we assign a \
crazy number... Rather than check if it is empty -- it could contain only whitespaces \
for instance, and this code will assume that you meant H = 0 in that case. Even \
otherwise, fields.at(9).isEmpty() looks cleaner. I'm not sure if a blank string will \
cause a result of '0' and ok=true, or a random result and ok=false, though. Need to \
check the docs.

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3221>

    Oh, so I'm the idiot responsible for these atrociously high magnitudes. So if M1, \
M2, K1, K2 work fine, you should probably get rid of H and G altogether from the \
code. Also, we need to let Jeamy Lee know.

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3223>

    Yes, this is better. Setting it to 101 makes more sense than my stupid setting it \
to -101. Sure.

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3224>

    Again, unnecessary whitespace. git diff will show these red blotches as well (I \
find them in my patches all the time) if you've enabled color in your .gitrc or \
whatever.

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3226>

    Sure. This looks good. Except I still don't like the fields.at(21) == "", like I \
said before.

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3227>

    Oh wait, I just realized you designed it all to be a CSV. In which case, this is \
acceptable. Sorry, I thought you were dealing with fixed-width fields. Still, I'd use \
.isEmpty().

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3228>

    Hmm, I wonder what 2400...0.5 is. I know it's not your code.

kstars/skycomponents/cometscomponent.cpp
<http://git.reviewboard.kde.org/r/101650/#comment3229>

    kDebug(), can be removed if you like. Not too particular about that.

kstars/skyobjects/kscomet.h
<http://git.reviewboard.kde.org/r/101650/#comment3231>

    Don't you have methods to return M1 and M2? Are those not required?

kstars/skyobjects/kscomet.h
<http://git.reviewboard.kde.org/r/101650/#comment3230>

    Stray whitespace inserted?

- Akarsh

On June 17, 2011, 5:15 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101650/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 5:15 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Summary
> -------
> 
> The patch is dirty now. Will look into it. This patch fixes the magnitude parameter \
> of observable comets by using a different formula altogether. T-Mag = M1 + \
> 5*log10(rearth) + k1*log10(rsun). Comets for which data are not available will have \
> abnormal magnitudes of 99. For formula refer: http://ssd.jpl.nasa.gov/horizons.cgi
> 
> Changed CometsComponent::updateDataFile() to store the k1,k2 parameters as well in \
> the comets.dat file Changed CometsComponent::loadData() to load M1, M2, K1, K2 \
> parameters as well. Also if M1, M2, K1, K2 data are not available set abnormal \
> values as default. Changed KSComet.h and KSComet.cpp to accept M1, M2, K1, K2 \
> parameters as well. Also modified KSComet::findMagnitude() to use the above \
> formula. Changed setMag() function in SkyObject.h so that for any magnitudes >=30 \
> abnormally high value(99) is set.  
> 
> Diffs
> -----
> 
> kstars/dialogs/detaildialog.cpp 3d669ef 
> kstars/skycomponents/cometscomponent.cpp 4a2851b 
> kstars/skyobjects/kscomet.h 5a858ee 
> kstars/skyobjects/kscomet.cpp e665c70 
> kstars/skyobjects/skyobject.h 6f6a061 
> 
> Diff: http://git.reviewboard.kde.org/r/101650/diff
> 
> 
> Testing
> -------
> 
> Tested for various comets.
> 
> 
> Thanks,
> 
> Samikshan
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101650/">http://git.reviewboard.kde.org/r/101650/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line145" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">122</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="n">H</span>      <span class="o">=</span> <span class="n">fields</span><span \
class="p">.</span><span class="n">at</span><span class="p">(</span> <span \
class="mi">9</span> <span class="p">).</span><span class="n">toFloat</span><span \
class="p">(</span> <span class="o">&amp;</span><span class="n">ok</span> <span \
class="p">);</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">138</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">	<span class="k">if</span><span \
class="p">(</span><span class="n">fields</span><span class="p">.</span><span \
class="n">at</span><span class="p">(</span><span class="mi">9</span><span \
class="p">)</span><span class="o">==</span><span class="s">&quot;&quot;</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, why \
not the if( !ok ) approach? If string conversion fails, we assign a crazy number... \
Rather than check if it is empty -- it could contain only whitespaces for instance, \
and this code will assume that you meant H = 0 in that case. Even otherwise, \
fields.at(9).isEmpty() looks cleaner. I&#39;m not sure if a blank string will cause a \
result of &#39;0&#39; and ok=true, or a random result and ok=false, though. Need to \
check the docs.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line150" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">143</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">		<span \
class="n">G</span> <span class="o">=</span> <span class="o">-</span><span \
class="mf">101.0</span><span class="p">;</span> <span class="c1">// Same with slope \
parameter</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, so \
I&#39;m the idiot responsible for these atrociously high magnitudes. So if M1, M2, \
K1, K2 work fine, you should probably get rid of H and G altogether from the code. \
Also, we need to let Jeamy Lee know.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line164" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">157</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">		<span \
class="n">M1</span> <span class="o">=</span> <span class="mf">101.0</span><span \
class="p">;</span><span class="ew">        </span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, this \
is better. Setting it to 101 makes more sense than my stupid setting it to -101. \
Sure.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line167" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">160</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew">	</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again, \
unnecessary whitespace. git diff will show these red blotches as well (I find them in \
my patches all the time) if you&#39;ve enabled color in your .gitrc or \
whatever.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line192" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">185</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew">	</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure. This \
looks good. Except I still don&#39;t like the fields.at(21) == &quot;&quot;, like I \
said before.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line193" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">186</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">	<span \
class="k">if</span><span class="p">(</span><span class="n">fields</span><span \
class="p">.</span><span class="n">at</span><span class="p">(</span><span \
class="mi">21</span><span class="p">)</span><span class="o">==</span><span \
class="s">&quot;&quot;</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh wait, I \
just realized you designed it all to be a CSV. In which case, this is acceptable. \
Sorry, I thought you were dealing with fixed-width fields. Still, I&#39;d use \
.isEmpty().</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line208" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
CometsComponent::selected() {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">143</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="n">JD</span> <span class="o">=</span> <span class="kt">double</span><span \
class="p">(</span> <span class="n">mJD</span> <span class="p">)</span> <span \
class="o">+</span> <span class="mf">2400000.5</span><span \
class="p">;</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">201</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">	<span class="n">JD</span> <span \
class="o">=</span> <span class="kt">double</span><span class="p">(</span> <span \
class="n">mJD</span> <span class="p">)</span> <span class="o">+</span> <span \
class="mf">2400000.5</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I \
wonder what 2400...0.5 is. I know it&#39;s not your code. </pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line244" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skycomponents/cometscomponent.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
CometsComponent::draw( SkyPainter *skyp )</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">236</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">		<span \
class="c1">//kDebug()&lt;&lt;&quot;Comet: Magnitude &quot;&lt;&lt; \
com-&gt;mag()&lt;&lt;endl;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kDebug(), \
can be removed if you like. Not too particular about that.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24596#file24596line111" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skyobjects/kscomet.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">111</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">     */</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don&#39;t \
you have methods to return M1 and M2? Are those not required?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101650/diff/1/?file=24596#file24596line259" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/skyobjects/kscomet.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">protected:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">240</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QString</span> <span class="n">OrbitID</span><span class="p">,</span> <span \
class="n">OrbitClass</span><span class="p">,</span> <span \
class="n">Dimensions</span><span class="p">;</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">259</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QString</span> <span class="n">OrbitID</span><span class="p">,</span> <span \
class="n">OrbitClass</span><span class="p">,</span> <span class="n">Dimensions</span> \
<span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stray \
whitespace inserted?</pre> </div>
<br />

<p>- Akarsh</p>

<br />
<p>On June 17th, 2011, 5:15 a.m., Samikshan Bairagya wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars.</div>
<div>By Samikshan Bairagya.</div>

<p style="color: grey;"><i>Updated June 17, 2011, 5:15 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch is dirty now. Will look into it. This patch fixes the \
magnitude parameter of observable comets by using a different formula altogether. \
T-Mag = M1 + 5*log10(rearth) + k1*log10(rsun). Comets for which data are not \
available will have abnormal magnitudes of 99. For formula refer: \
http://ssd.jpl.nasa.gov/horizons.cgi

Changed CometsComponent::updateDataFile() to store the k1,k2 parameters as well in \
the comets.dat file Changed CometsComponent::loadData() to load M1, M2, K1, K2 \
parameters as well. Also if M1, M2, K1, K2 data are not available set abnormal values \
as default. Changed KSComet.h and KSComet.cpp to accept M1, M2, K1, K2 parameters as \
well. Also modified KSComet::findMagnitude() to use the above formula. Changed \
setMag() function in SkyObject.h so that for any magnitudes &gt;=30 abnormally high \
value(99) is set. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested for various comets.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/dialogs/detaildialog.cpp <span style="color: grey">(3d669ef)</span></li>

 <li>kstars/skycomponents/cometscomponent.cpp <span style="color: \
grey">(4a2851b)</span></li>

 <li>kstars/skyobjects/kscomet.h <span style="color: grey">(5a858ee)</span></li>

 <li>kstars/skyobjects/kscomet.cpp <span style="color: grey">(e665c70)</span></li>

 <li>kstars/skyobjects/skyobject.h <span style="color: grey">(6f6a061)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101650/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 