From kstars-devel  Fri Aug 29 01:08:11 2008
From: Jason Harris <kstars () 30doradus ! org>
Date: Fri, 29 Aug 2008 01:08:11 +0000
To: kstars-devel
Subject: Re: [Kstars-devel] [PATCH] Prettier (?) stars
Message-Id: <11EF8FC2-BE70-4AB8-BEA4-54283D7FCC62 () 30doradus ! org>
X-MARC-Message: https://marc.info/?l=kstars-devel&m=121997215117011

Hi Médéric,

The patch looks good, except for one bug: the saturation parameter in  
the Colors page of the Config window is now inverted: *lower*  
saturation values lead to *more* saturated star colors.

Jason

On Aug 27, 2008, at 10:43 PM, Médéric Boquien wrote:

> Hello,
>
> I have polished the patch to make it a bit cleaner and faster. I  
> think it is
> ready for inclusion if you think it looks better than currently.
> I have timed the speed difference with 4.1 branch. It is hard to  
> compare
> directly as the number of stars is not the same but it seems to take  
> about the
> same time. For information, on a core 2 Q9450 with a nvidia graphics  
> card
> running the binary driver, with the extended catalogue (setting the  
> number of
> stars on screen to the minimum), fairly zoomed out, it takes ~100ms/ 
> image. It
> looks a bit long, especially if we want to increase the number of  
> stars
> displayed.
>
> Regards,
>
> Médéric
>
> Le Thursday 21 August 2008 02:02:21 Jason Harris, vous avez écrit :
>> Thanks Mederic.
>>
>> BTW, note that this shouldn't be any slower than the original star
>> images, despite the fact that drawing them is more complicated.  Star
>> images are cached and blitted to the screen.  So constructing the  
>> star
>> image cache will be a bit slower, but that is a very rare operation.
>>
>> Jason
>>
>> On Wed, Aug 20, 2008 at 10:32 PM, Médéric Boquien  
>> <mboquien@free.fr> wrote:
>>> Hello,
>>>
>>> I have made a patch which modifies the aspect of stars in the  
>>> "Classic"
>>> and "Moonless night" colour schemes. In summary, instead of  
>>> drawing a
>>> coloured annulus around the central white circle, i use the change  
>>> the
>>> saturation and the transparency in function of the radius, so it  
>>> looks a
>>> bit more smooth and blends with the background. The attached patch  
>>> is
>>> included if you want to play and if you find a better transfer  
>>> function
>>> for the saturation and the transparency channels. Note, it is not  
>>> 100%
>>> clean, and i do not expect it to be committed yet. For the most
>>> impatient, i have also included a screenshot. What do you think of  
>>> the
>>> new stars. Are they better? Worse? How could they be improved?
>>>
>>> Thanks,
>>>
>>> Médéric
>>>
>>> _______________________________________________
>>> Kstars-devel mailing list
>>> Kstars-devel@kde.org
>>> https://mail.kde.org/mailman/listinfo/kstars-devel
>
> <colors_final.patch>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel