[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] branches/kstars/unfrozen/kstars/kstars/tools
From:       Akarsh Simha <akarshsimha () gmail ! com>
Date:       2008-07-03 9:12:20
Message-ID: 20080703090020.GC31847 () PENGUIN
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


> Akarsh, your commit message mentioned fixing a few bugs that my original patch 
> revealed...was there anything besides reducing the tolerance of findPrecise() to 1 
> minute?

Yes. There was. I had passed prevSign instead of Sign, into
findPrecise, which was causing it to find minima only when it passed a
maximum (because of the prevSign == 1 that was there earlier) - so it
was taking much longer than it should have taken. When we removed
prevSign, most minima were listed twice, because findPrecise() was
called once for the minimum and once for the maximum.

Basically, the passing of prevSign instead of Sign caused findPrecise
to stray away from the target point and find other 'distant'
extrema. That's now fixed. With this fix, I could check prevSign ==
-1, which is the correct check for minima.

That's the other fix made.

Regards
Akarsh

["signature.asc" (application/pgp-signature)]

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel


[prev in list] [next in list] [prev in thread] [next in thread]