[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    [Kstars-devel] problem with image dump mode
From:       Jason Harris <kstars () 30doradus ! org>
Date:       2007-12-20 7:40:03
Message-ID: 476A1C53.6010903 () 30doradus ! org
[Download RAW message or body]

Hi,

I just noticed that the image dump mode crashes without producing an 
image.  The reason is that we pass a KStars pointer through all of the 
draw functions in skycomponents, but there is no KStars object when 
using dump mode.

Now, most (if not all) of the uses of the KStars pointer in these draw 
functions is simply to get pointers to the SkyMap and KStarsData 
objects.  In those cases, the fixes are simple, but pretty pervasive.

SkyMap is a singleton, so there's no need to reference it through 
KStars.  If we make KStarsData a singleton as well (which we should do 
anyway), then there's no need for this use of the KStars pointer either.

There may be uses of KStars inside the draw functions besides pointing 
to SkyMap and KStarsData, but I'm guessing that these other uses will be 
few in number.

I'm not comfortable making a big change like this so close to the 
release, but neither do I want to release a broken dump mode.  I wish I 
had caught this problem earlier.  Any suggestions on how to proceed?

regards,
Jason
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]