[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] KDE/kdeedu/libkdeedu/extdate
From:       Jason Harris <jharris () 30doradus ! org>
Date:       2006-09-15 21:50:00
Message-ID: 450B2008.9080601 () 30doradus ! org
[Download RAW message or body]

In case it wasn't clear from the commit log, this fixes the crash in the 
"Set Time" tool that Jasem pointed out today.

regards,
Jason

Jason Harris wrote:
> SVN commit 584944 by harris:
> 
> Fixed crash condition in ExtDate::fromString(QString, QDateFormat).
> When using the TextFormat QDateFormat, the code creates a QStringList 
> from the space-separated fields of the input string, but it then assumed 
> that the stringlist contains at least three members, which caused a 
> crash when this was not the case.  Now, it will return an invalid 
> ExtDate if the stringlist contains fewer than three members.
> 
> Thanks for the tip, Jasem.
> 
> CCMAIL: kde-edu@kde.org
> CCMAIL: kstars-devel@kde.org
> 
> 
> 
>  M  +4 -0      extdatetime.cpp  
> 
> 
> --- trunk/KDE/kdeedu/libkdeedu/extdate/extdatetime.cpp #584943:584944
> @@ -494,6 +494,10 @@
>  			//Three possible date formats:
>  			//dd mth yyyy; mth dd yyyy; wkd mth dd yyyy
>  			QStringList ss = s.split( " " );
> +
> +			//Return invalid if we don't have at least 3 fields
> +			if ( ss.size() < 3 ) return dt;
> +
>  			bool ok = false;
>  			int month = -1;
>  			uint imonth = 0;
> _______________________________________________
> Kstars-devel mailing list
> Kstars-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kstars-devel
> 

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]