[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ksecretservice-devel
Subject:    [Ksecretservice-devel] Re: Item attributes types inconsistency
From:       Valentin Rusu <kde () rusu ! info>
Date:       2011-03-13 21:47:24
Message-ID: 4D7D3B6C.7040201 () rusu ! info
[Download RAW message or body]

Hello,

Please be advised that I think that the spec has a little inconsistency
when specifying item attributes.

First, when creating an item, the signature of the CreateItem has a
"properties" arg of type "a{sv}".

Secondly, the created item has a "attributes" of type "a{ss}". 

This isn't consistent and I propose to stick with "a{sv}" as it's more
flexible, as per attached patch.

Any thoughts?

Cheers,
Valentin




["0001-Item-attributes-should-all-be-a-sv.patch" (text/x-patch)]

From 048a5427b107e7ec3f236149496f42d49c180851 Mon Sep 17 00:00:00 2001
From: Valentin Rusu <kde@rusu.info>
Date: Sun, 13 Mar 2011 22:35:03 +0100
Subject: [PATCH] Item attributes should all be a{sv}

---
 secret-service/org.freedesktop.Secrets.xml |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/secret-service/org.freedesktop.Secrets.xml \
b/secret-service/org.freedesktop.Secrets.xml index def4f62..8e34e50 100644
--- a/secret-service/org.freedesktop.Secrets.xml
+++ b/secret-service/org.freedesktop.Secrets.xml
@@ -128,7 +128,7 @@ properties = { "Label": "MyCollection" }
 
             <method name="SearchItems">
                 <tp:docstring>Find items in any collection.</tp:docstring>
-                <arg name="attributes" type="a{ss}" direction="in">
+                <arg name="attributes" type="a{sv}" direction="in">
                     <tp:docstring>Find secrets in any collection.</tp:docstring>
                 </arg>
                 <arg name="unlocked" type="ao" direction="out">
@@ -268,7 +268,7 @@ properties = { "Label": "MyCollection" }
 
             <method name="SearchItems">
                 <tp:docstring>Search for items in this collection matching the \
                lookup attributes.</tp:docstring>
-                <arg name="attributes" type="a{ss}" direction="in">
+                <arg name="attributes" type="a{sv}" direction="in">
                     <tp:docstring>Attributes to match.</tp:docstring>
                 </arg>
                 <arg name="results" type="ao" direction="out">
@@ -367,7 +367,7 @@ properties = {
                 <tp:docstring>Whether the item is locked and requires \
authentication, or not.</tp:docstring>  </property>
 
-            <property name="Attributes" type="a{ss}" access="readwrite">
+            <property name="Attributes" type="a{sv}" access="readwrite">
                 <tp:docstring>The lookup attributes for this item.</tp:docstring>
             </property>
 
-- 
1.7.3.4



_______________________________________________
Ksecretservice-devel mailing list
Ksecretservice-devel@kde.org
https://mail.kde.org/mailman/listinfo/ksecretservice-devel


[prev in list] [next in list] [prev in thread] [next in thread]