[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request 130225: Added autotests for kopete chat window
From: Laurent Montel <montel () kde ! org>
Date: 2017-10-08 17:32:39
Message-ID: 20171008173239.11009.21425 () mimi ! kde ! org
[Download RAW message or body]
--===============4797829172042318470==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130225/#review103811
-----------------------------------------------------------
Ship it!
Ship It!
- Laurent Montel
On août 12, 2017, 10:23 après-midi, Vijay Krishnavanshi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130225/
> -----------------------------------------------------------
>
> (Updated août 12, 2017, 10:23 après-midi)
>
>
> Review request for Kopete, Laurent Montel and Pali Rohár.
>
>
> Repository: kopete
>
>
> Description
> -------
>
> This autotest attempts to tets the kopete chat window style. But one issue that I \
> am facing is that it looks for style in QStandardPaths::DataLocation/styles for \
> styles but I want to change it to the current CMAKE_SOURCE_DIR.
>
> Diffs
> -----
>
> tests/kopete/CMakeLists.txt 2f9b0db
> tests/kopete/kopetechatwindowtest.cpp PRE-CREATION
> tests/kopete/styles/TestStyle/Contents/Info.plist PRE-CREATION
> tests/kopete/styles/TestStyle/Contents/Resources/Header.html PRE-CREATION
> tests/kopete/styles/TestStyle/Contents/Resources/Incoming/Content.html PRE-CREATION \
> tests/kopete/styles/TestStyle/Contents/Resources/Incoming/NextContent.html \
> PRE-CREATION tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/Content.html \
> PRE-CREATION tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/NextContent.html \
> PRE-CREATION tests/kopete/styles/TestStyle/Contents/Resources/Status.html \
> PRE-CREATION tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant1.css \
> PRE-CREATION tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant2.css \
> PRE-CREATION tests/kopete/styles/TestStyle/Contents/Resources/main.css \
> PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/130225/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vijay Krishnavanshi
>
>
--===============4797829172042318470==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130225/">https://git.reviewboard.kde.org/r/130225/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Laurent Montel</p>
<br />
<p>On août 12th, 2017, 10:23 après-midi UTC, Vijay Krishnavanshi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kopete, Laurent Montel and Pali Rohár.</div>
<div>By Vijay Krishnavanshi.</div>
<p style="color: grey;"><em>Updated août 12, 2017, 10:23 après-midi</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kopete
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This autotest attempts to tets the kopete chat window \
style. But one issue that I am facing is that it looks for style in \
QStandardPaths::DataLocation/styles for styles but I want to change it to the current \
CMAKE_SOURCE_DIR.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/kopete/CMakeLists.txt <span style="color: grey">(2f9b0db)</span></li>
<li>tests/kopete/kopetechatwindowtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Info.plist <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Header.html <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Incoming/Content.html <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Incoming/NextContent.html <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/Content.html <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/NextContent.html <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Status.html <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant1.css <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant2.css <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kopete/styles/TestStyle/Contents/Resources/main.css <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130225/diff/1/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4797829172042318470==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic